Skip to content

feat: PR from asset-metadata-service for token onboardings - #10081

Merged
prajwalu142 merged 1 commit into
masterfrom
ams-bot-tokens
Oct 27, 2026
Merged

prajwalu142 merged 1 commit into
masterfrom
ams-bot-tokens

Conversation

@asset-metadata-bot

@asset-metadata-bot asset-metadata-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This is a token onboarding PR opened by asset-metadata-service.

Post-regen fixes (manual)

  • Squashed the two AMS bot commits into a single commit.
  • Restored entries dropped by the AMS regeneration, verbatim from master with their exact feature lists, in botTokens.ts / botOfcTokens.ts:
    • hteth:tgku / ofchteth:tgku
    • hteth:stzamakms / ofchteth:stzamakms
    • hteth:WBTC / ofchteth:WBTC
  • Restored CoinFeature.STAKING on hteth:zamamock, which the regen dropped from its feature list.
  • Fixed @bitgo/statics module-load crash: baseeth:zaru (the only mainnet-BaseChain Erc20Coin) threw "unsupported network" because getErc20TokenConfig had no Networks.main.basechain case — added baseeth mapping (ERC-20 path only; no ERC-7984 case since Base support for ERC-7984 is unconfirmed).

Verification

  • Every restored block byte-matches master; full line-level audit of both bot files vs master shows zero remaining drops or mutations (all other diffs are pure regen additions/reordering).
  • Built @bitgo/statics: module load succeeds; all restored tokens resolve with expected features; getFormattedErc20Tokens maps baseeth:zaru to coin: baseeth / network: Mainnet.

@asset-metadata-bot
asset-metadata-bot Bot requested a review from a team as a code owner October 27, 2026 18:15

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@prajwalu142
prajwalu142 force-pushed the ams-bot-tokens branch 2 times, most recently from 3dc9280 to 102a527 Compare October 27, 2026 18:32
@dpkjnr

dpkjnr commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

can you update the PR description and use correct ticket number in the commit message?

@prajwalu142
prajwalu142 merged commit 7cac5e9 into master Oct 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants