Repository navigation
feat: enable Safe recovery for HBAR - #10038
Merged
Merged
Conversation
- Cut Hbar.recover() over to the lazy ExternalEd25519Signer, dropping the pre-made externalBackupSignature hook (mirrors the ALGO cutover) - Register hbar/thbar in ED25519_MULTISIG_COIN_ENCODERS; omit rootAddres for HBAR since Hedera account IDs are network-assigned - Echo derived public keys in signed Safe recovery for HBAR and ALGO, leaving legacy paths unchanged - Fix external signer mutation: verify against the original message byte - Validate bitgoKey before node queries and signing Ticket: WCN-2897
Contributor
Contributor
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
davidkaplanbitgo
approved these changes
Oct 22, 2026
nvrakesh06
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables Safe (slot-2 ed25519Multisig) recovery for HBAR and fixes the Safe
key-echo for HBAR and ALGO (WCN-2897).
Hbar.recover()now signs the backup child lazily viaExternalEd25519Signerover the built transaction's bodyBytes, replacingthe pre-made
externalBackupSignaturehook (mirrors ALGO's feat: enable Safe recovery for ALGO #10012 cutover)hbar/thbarregistered inED25519_MULTISIG_COIN_ENCODERS;rootAddressomitted for HBAR (network-assigned account IDs) so thecaller-supplied address survives param composition
(
userKey/backupKey/bitgoKey/rootAddress) for HBAR and ALGO;legacy signed/unsigned paths unchanged
signWithExternalEd25519Signerverifies against theoriginal message bytes — a mutating signer can no longer alter the
transaction body
bitgoKeybefore any node query or signingTicket: WCN-2897