Repository navigation
feat(express): run Express image on Node 24.22.1 - #10023
Open
zahin-mohammad wants to merge 1 commit into
Open
zahin-mohammad wants to merge 1 commit into
zahin-mohammad wants to merge 1 commit into
Conversation
Align the Express Docker image with the root .nvmrc (24.22.1) by moving all three stages from node:22.23.4-bookworm-slim to node:24.22.1-bookworm-slim, pinned to the multi-arch index digest published on Docker Hub (includes linux/amd64 and linux/arm64). Stacked on the Node 22.23.4 patch PR (#10022); descoped from that P0 fix. Ticket: WCN-3734 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Contributor
Author
Local verification of this branch (Node 24.22.1 image)Built with `docker build --platform=linux/amd64 -t bitgo/express:wcn-3185-test .` (exit 0). Run under Colima on an arm64 host, so the amd64 image ran emulated.
Not run yet: HTTPS/TLS handshake, body-parser and HMAC raw-body path, proxy fallback, signer mode, lightning signer routes, `modules/express` unit suite, arm64 build. Staying draft until those are done. |
danielpeng1
previously approved these changes
Oct 21, 2026
danielpeng1
reviewed
Oct 21, 2026
danielpeng1
left a comment
danielpeng1
left a comment
Contributor
There was a problem hiding this comment.
fyi this is just merging into your other feature branch
Charan-Ratlan
previously approved these changes
Oct 22, 2026
9 of 13 tasks
zahin-mohammad
changed the base branch from
zahinmohammad/wcn-3321-runtime-move-bitgo-express-dockerfile-stages-to-fixed-node
to
master
October 22, 2026 17:31
zahin-mohammad
dismissed stale reviews from Charan-Ratlan and danielpeng1
October 22, 2026 17:31
The base branch was changed.
Contributor
Author
Weird that the base didn't change automatically. |
danielpeng1
approved these changes
Oct 22, 2026
Contributor
|
Try rebasing or something else to unstuck the CI |
mukeshsp
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves all three stages of the root
Dockerfilefromnode:22.23.4-bookworm-slimtonode:24.22.1-bookworm-slim@sha256:55fb5f5a527ea2c5c4a95f963e48ef90aa38c7b346054fdc8ee9957a2b55d205, so the Express image matches the root.nvmrc(24.22.1).Stacked on #10022 (the P0 Node 22.23.4 patch). This PR is descoped from that fix so the security patch stays a minor bump on the supported Node 22 major. Merge #10022 first; this PR's base will retarget to
master.Digest is the multi-arch index from Docker Hub (
docker buildx imagetools inspect node:24.22.1-bookworm-slim), coveringlinux/amd64andlinux/arm64/v8.Risk: major-version runtime change
Customers self-host this image. Native modules (
argon2,secp256k1,blake2b-wasm) must rebuild against the Node 24 ABI.Verification status
docker build,node --versionin the image, native modulerequire, Express unit suite. A build is in progress locally; results will be added here. Marked draft until then.Ticket: WCN-3734
🤖 Generated with Claude Code