Repository navigation
Conversation
Move the component-wise travel increase calculation out of plot_component_wise_travel_increase and call it unconditionally in Metric.calculate_all, so rel_increase_comp is available when make_plots=False. Also write the LTN-level rel_increase to the actual components via get_ltns() instead of the throwaway dicts from get_partition_nodes().
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
Nice, thank you! |
Member
Author
|
Yes, this is the case. Have good travels |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the component-wise travel increase calculation out of
plot_component_wise_travel_increaseinto a newwrite_component_wise_travel_increaseinmeasures.py, called fromMetric.calculate_all.rel_increase_compis available independent of the plotting option.fixes the LTN-level
rel_increasebeing written to throwaway dicts fromget_partition_nodes()instead of the actual components. Registersrel_increase_compin the graphml dtype map.Related Issue
Fixes #136
Type of Change
How Has This Been Tested?
Test configuration:
Screenshots (if applicable)
Checklist
Additional Notes