Repository navigation
Make /cba reload confirm and apply world depth live - #121
Merged
Merged
Conversation
- CustomHeightLimitations read world depth once at startup, so a reloaded world-depth was ignored until restart. It now reads the live settings on each check. - Replace the default admin reload subcommand with one that sends a confirmation message, since the BentoBox default reloads silently. - Add the reloaded message to all locales, add the missing cave-limit-reached string to locales that lacked it, and fill in the previously empty id and ro locale files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An admin on Discord reported that
/cba reload"doesn't work". It does reloadconfig.yml, but it gives no feedback, and one setting wasn't actually picked up.Changes
CustomHeightLimitationssavedworldDepth - 1in its constructor, so after a reload the generator used the new depth but players were still blocked at the old ceiling until a restart. It now reads the live settings on each check.AdminReloadCommandreloads silently. A newAdminReloadConfirmCommandreplaces it under the samereload/rllabels and sendscaveblock.commands.admin.reload.reloaded. The message also explains that changes only apply to newly generated chunks, and that world name, dimensions and command aliases need a restart.general.errors.cave-limit-reachedto cs, es, ja, lv, pl, vi and zh-CN.id.ymlandro.yml, which have been empty placeholders since 2019. These are complete translations and would benefit from review by a native speaker.Testing
mvn test: 79 tests pass, including the newtestMoveUsesReloadedWorldDepth.The same silent-reload problem affects every addon that uses the default reload command, so a confirmation message in BentoBox's
AdminReloadCommanditself would fix it everywhere.🤖 Generated with Claude Code