Repository navigation
Release 3.23.4 - #3102
Merged
Merged
Release 3.23.4#3102
Conversation
#2767 tried this by only cancelling clicks in the panel itself, but that stopped icon pickers seeing clicks in the player's inventory (#2776) and let shift-clicks and drags move items into panels, where they were lost. It was reverted in 3.11.1. This version keeps routing player-inventory clicks to the panel and only lets them through when: - the action cannot move an item into the panel (pickup, place, swap, hotbar swap, drop, bundles; not shift-click or double-click), and - the panel has no listener, or its listener opts in via the new PanelListener#allowsPlayerInventoryClicks() (default false, so addon icon pickers are unaffected). TabbedPanel and AbstractRefreshingPanel opt in. A held item can never be placed in a panel, even if a click handler uncancels the click, and drags that touch panel slots are cancelled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y-clicks Let players use their own inventory while a panel is open
With create-obsidian-platform: false the portal event was never cancelled, so the server teleported the player in the same tick to a spot that could have no floor, and the scheduled safe spot teleport then found the player already in the End and did nothing. Cancel the event when the End arrival is unsafe so the safe spot teleport runs, and cancel repeat portal events while that teleport is pending so the server cannot send the player to the vanilla End spawn instead. Applies to players and entities. Also teleport to the centre of the block when a safe spot pod is built. The target was the requested location plus 0.5, which lands on a block edge when the location is already off-centre. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Safe End arrival when the obsidian platform is off
Addon.getConfig() returned null when the addon had no config.yml, so saveConfig() threw an NPE. Return an empty YamlConfiguration instead, matching JavaPlugin.getConfig(). MongoDBDatabase passed the lazily initialised connector field to the handler; hold it in a local so it is provably non-null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 3.23.4.
Draft release notes: see the 3.23.4 draft release.
🤖 Generated with Claude Code