tests: Match Core initializer signature - #117
Open
BenWestgate wants to merge 1 commit into
Open
BenWestgate wants to merge 1 commit into
BenWestgate wants to merge 1 commit into
Conversation
BenWestgate
added
area: ci
The CLI fake still accepted an obsolete private keyword after the earlier cleanup. Remove it so a production call using that unsupported argument cannot pass the fake and fail only against real Bitcoin Core. Refs #38.
BenWestgate
force-pushed
the
codex/38-core-stub-signature
branch
from
October 4, 2026 06:59
90b9efe to
6fc7e68
Compare
BenWestgate
marked this pull request as draft
October 4, 2026 07:00
BenWestgate
commented
Oct 4, 2026
BenWestgate
left a comment
BenWestgate
left a comment
Owner
Author
There was a problem hiding this comment.
AI-generated review (Codex), posted at the maintainer's request.
ACK 6fc7e68. The test fake now matches the actual initializer signature.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
marked this pull request as ready for review
October 4, 2026 22:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #38.
The prior dead-code cleanup removed the unused fake state but left its obsolete private= keyword in _FakeBitcoinCore.initialize. Production BitcoinCore.initialize does not accept that keyword. Remove the one parameter so future accidental calls fail in CLI tests instead of only against real Core.
Verification: 232 CLI tests passed on this branch; git diff --check passes. No runtime code changed.
AI assistance was used to find and prepare this one-line test correction. Human review remains with the maintainer.