Repository navigation
Expose deterministic and Gaussian ODE flow transitions - #442
Open
mattlevine22 wants to merge 8 commits into
Open
mattlevine22 wants to merge 8 commits into
mattlevine22 wants to merge 8 commits into
Conversation
Collaborator
Author
|
bleh AI |
DanWaxman
requested changes
Nov 19, 2026
DanWaxman
left a comment
Collaborator
There was a problem hiding this comment.
This looks overall reasonable... Could you also update the developer API change accordingly?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to simplify/generalize the state evolution classes coming from ODEFlow discretization, with the aim of resolving #441. However, I now see that the other barrier there lies in supporting time-varying transitions from
t_now -> t_next, which is a separate undertaking. Despite no new features from this PR, I do think it is worthwhile, as it sets us on a better footing for treating ODEFlow discretization as simply GaussianStateEvolutions or DeterminsticStateEvolutions---less checks later on.ODE flow transitions
Discretizer(ODEFlowConfig(...))now exposes the distribution of an ODE transition through its state-evolution class.jitter_scaleDeterministicStateEvolutionGaussianStateEvolutionjitter_scale**2 * IBoth classes share the private
_ODEFlowStateEvolutionbase and compute.Fwith the configured ODE solver. Default handler selection now recognizes a jittered flow through the existing Gaussian type check.Discrete filter behavior
ValueErrorfor anyDeterministicStateEvolutionand suggests EnKF for Gaussian observations. For an ODE flow, the error also explains that settingjitter_scale > 0enables EKF.NotImplementedErrorfor either ODE flow. Dynestyx’s shared discrete EKF/UKF adapter calls nonlinear transitions asF(x, u, 0, 0)and nonlinear observations ash(x, u, 0). Both filters and smoothers use this adapter. An ODE flow needs the elapsed time between observations even when its drift is autonomous. See Warn when discrete CD-Dynamax EKF/UKF ignores time-varying callables #231 for the existing warning about placeholder times.The goal of #441 is to run a discrete UKF on an ODE flow. Dynestyx currently routes
UKFConfigonly tocd_dynamax. Cuthbert provides unscented quadrature, but using it throughUKFConfigrequires a Dynestyx integration. The UKF reproducer in #441 remains open.Verification
Two assertions in existing discretizer tests check the transition class at zero and positive jitter. All 24 tests in
tests/test_discretizer_methods.pypassed locally.