Repository navigation
Conversation
anushri10
commented
Jul 24, 2026
- Added MixedStateDistribution and SLDS components
- Add RBPFConfig and cd-dynamax RBPF integration (this assumes cd-dynamax RBPF marginal_loglik support is integrated)
- added a test script for SLDS with RBPF
|
Thanks Anushri! I'll review this and give feedback, but let's wait for #255 to clear before merging this. |
|
Quick update -- working on it this week! |
|
Excellent! I think landing the SLDS updates in CD-Dynamax will be a big first step! |
| return jnp.concatenate([z[..., None].astype(x.dtype), x], axis=-1) | ||
|
|
||
| def log_prob(self, value): | ||
| z = jnp.rint(value[..., 0]).astype(jnp.int32) |
There was a problem hiding this comment.
This will round a category of 1.4 to 1 and proceed from there.
On one hand, that is "bad" because the log_prob should be -Inf for 1.4 (it is invalid).
- So, we could do some checks here to fix that.
On the other hand, rounding could be advantageous if we later try to naively use a different filter with these distributions.
I'll open a PR on your repo to start filling in these suggestions
|
|
||
|
|
||
| def _prepare_slds_rbpf_inputs(dynamics, obs_values, obs_times, ctrl_times, ctrl_values): | ||
| emissions = obs_values[:, None] if obs_values.ndim == 1 else obs_values |
There was a problem hiding this comment.
I'll look to see if we need these .ndim checks or if we can promise a single shape earlier on in the code
|
Overall status:
However, there are some outstanding issues beyond what I addressed in the PR that I've gotten chatGPT to help me identify + summarize:
|
|
Closing as superseded by #428. |