Repository navigation
fix(VAPI-4457): scope SSML un-escape to SpeakSentence text - #148
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
ckoegel
reviewed
Nov 5, 2026
Comment on lines
+67
to
+73
| test('should un-escape SSML in a Gather SpeakSentence but not in Gather attributes', () => { | ||
| const gather = new Gather({ gatherUrl: 'https://example.com/?a=<b>' }, [new SpeakSentence('say <emphasis>this</emphasis>')]); | ||
| const bxml = gather.toBxml(); | ||
|
|
||
| expect(bxml).toContain('gatherUrl="https://example.com/?a=<b>"'); | ||
| expect(bxml).toContain('say <emphasis>this</emphasis>'); | ||
| }); |
Contributor
There was a problem hiding this comment.
can we move this test to the Gather test file since its specifically for that verb
ckoegel
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SSML un-escape (
<tag>-><tag>) ran over the whole serialized BXML, so it also rewrote escaped<...>inside XML attribute values into a raw<...>. A raw<is illegal in an attribute value, so the output was malformed XML and the API returnedinvalid_bxml.The un-escape now only applies to the text inside
<SpeakSentence>...</SpeakSentence>, matching the C# and Ruby SDKs. Attribute values and every other element keep their XML escaping.Jira: VAPI-4457
Validation
npx jest tests/unit/models/bxmlpasses (59 tests) andtsc --noEmitis clean.mainand pass on this branch.