DX-4156 Remove Env Vars from Unit Tests

.github/workflows/deploy.yml

@@ -13,21 +13,6 @@ jobs:
   deploy:
     name: Deploy SDK to NPM
     runs-on: ubuntu-latest
-    env:
-      BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }}
-      BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }}
-      BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }}
-      BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID }}
-      BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID }}
-      BW_NUMBER: ${{ secrets.BW_NUMBER }}
-      USER_NUMBER: ${{ secrets.USER_NUMBER }}
-      BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }}
-      OPERATING_SYSTEM: "ubuntu"
-      MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }}
-      MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }}
-      MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }}
-      MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }}
-      BW_NUMBER_PROVIDER: ${{ secrets.BW_NUMBER_PROVIDER }}
 
     steps:
       - name: Set Release Version

.github/workflows/test-pr.yml

@@ -9,20 +9,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref }}
   cancel-in-progress: true
 
-env:
-  BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }}
-  BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }}
-  BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }}
-  BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID }}
-  BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID }}
-  BW_NUMBER: ${{ secrets.BW_NUMBER }}
-  USER_NUMBER: ${{ secrets.USER_NUMBER }}
-  BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }}
-  MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }}
-  MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }}
-  MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }}
-  MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }}
-
 jobs:
   test:
     name: Test PR
@@ -46,6 +32,4 @@ jobs:
           yarn
           npm install -g @stoplight/prism-cli
           prism mock ./bandwidth.yml & yarn test-unit
-        env:
-          OPERATING_SYSTEM: ${{ matrix.os }}
         shell: bash

tests/unit/api/calls-api.test.ts

@@ -1,6 +1,7 @@
 import axios from 'axios';
 import { CallsApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_VOICE_APPLICATION_ID, BASE_CALLBACK_URL } from '../constants';
 import {
     CallbackMethodEnum,
     CallDirectionEnum,
@@ -138,7 +139,7 @@ describe('CallsApi', () => {
         test('should update a call', async () => {
             const updateCallBody: UpdateCall = {
                 state: CallStateEnum.Active,
-                redirectUrl: `${MANTECA_BASE_URL}/bxml/pause`
+                redirectUrl: `${BASE_CALLBACK_URL}/bxml/pause`
             };
 
             const { status } = await callsApi.updateCall(BW_ACCOUNT_ID, callId, updateCallBody);

tests/unit/api/conferences-api.test.ts

@@ -1,5 +1,6 @@
 import { ConferencesApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID, BASE_CALLBACK_URL } from '../constants';
 import {
     ConferenceStateEnum,
     RedirectMethodEnum,
@@ -79,11 +80,11 @@ describe('ConferencesApi', () => {
         test('should update conference', async () => {
             const updateConferenceBody: UpdateConference = {
                 status: ConferenceStateEnum.Active,
-                redirectUrl: `${MANTECA_BASE_URL}/bxml/pause`,
+                redirectUrl: `${BASE_CALLBACK_URL}/bxml/pause`,
                 redirectMethod: RedirectMethodEnum.Post,
                 username: 'username',
                 password: 'password',
-                redirectFallbackUrl: `${MANTECA_BASE_URL}/bxml/pause`,
+                redirectFallbackUrl: `${BASE_CALLBACK_URL}/bxml/pause`,
                 redirectFallbackMethod: RedirectMethodEnum.Post,
                 fallbackUsername: 'username',
                 fallbackPassword: 'password'

tests/unit/api/media-api.test.ts

@@ -1,5 +1,6 @@
 import { MediaApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID } from '../constants';
 
 describe('MediaApi', () => {
     const config = new Configuration({

tests/unit/api/messages-api.test.ts

@@ -1,6 +1,7 @@
 import axios from 'axios';
 import { MessagesApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_MESSAGING_APPLICATION_ID } from '../constants';
 import {
     ListMessageDirectionEnum,
     MessageDirectionEnum,

tests/unit/api/mfaapi.test.ts

@@ -1,6 +1,7 @@
 import axios from 'axios';
 import { MFAApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_VOICE_APPLICATION_ID, BW_MESSAGING_APPLICATION_ID } from '../constants';
 import { CodeRequest, VerifyCodeRequest } from '../../../models';
 
 describe('MFAApi', () => {

tests/unit/api/multi-channel-api.test.ts

@@ -1,6 +1,7 @@
 //@ts-nocheck
 import { MultiChannelApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_MESSAGING_APPLICATION_ID } from '../constants';
 import {
     MultiChannelChannelListRBMObject,
     MultiChannelMessageChannelEnum,

tests/unit/api/phone-number-lookup-api.test.ts

@@ -1,5 +1,6 @@
 import { PhoneNumberLookupApi } from "../../../api";
 import { Configuration } from "../../../configuration";
+import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER } from "../constants";
 import {
     AsyncLookupRequest,
     CompletedLookupStatusEnum,

tests/unit/api/recordings-api.test.ts

@@ -1,5 +1,6 @@
 import { RecordingsApi } from "../../../api";
 import { Configuration } from "../../../configuration";
+import { BW_ACCOUNT_ID, BASE_CALLBACK_URL } from "../constants";
 import {
     CallDirectionEnum,
     FileFormatEnum,
@@ -135,7 +136,7 @@ describe('RecordingsApi', () => {
     describe('transcribeCallRecording', () => {
         test('should create a transcription request', async () => {
             const transcribeRecording: TranscribeRecording = {
-                callbackUrl: `${MANTECA_BASE_URL}/transcriptions`,
+                callbackUrl: `${BASE_CALLBACK_URL}/transcriptions`,
                 tag: callId
             };
             const { status } =

tests/unit/api/statistics-api.test.ts

@@ -1,6 +1,7 @@
 import axios from 'axios';
 import { StatisticsApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID } from '../constants';
 
 describe('StatisticsApi', () => {
     const config = new Configuration({

tests/unit/api/toll-free-verification-api.test.ts

@@ -1,5 +1,6 @@
 import { TollFreeVerificationApi } from '../../../api';
 import { Configuration } from '../../../configuration';
+import { BW_ACCOUNT_ID } from '../constants';
 import {
     BusinessEntityTypeEnum,
     BusinessRegistrationTypeEnum,

tests/unit/api/transcriptions-api.test.ts

@@ -1,5 +1,6 @@
 import { TranscriptionsApi } from "../../../api";
 import { Configuration } from "../../../configuration";
+import { BW_ACCOUNT_ID } from "../constants";
 import { CallTranscriptionDetectedLanguageEnum, CallTranscriptionTrackEnum } from "../../../models";
 
 describe('TranscriptionsApi', () => {

tests/unit/constants.ts

@@ -0,0 +1,6 @@
+export const BW_ACCOUNT_ID = '9900000';
+export const BW_NUMBER = '+19195551234';
+export const USER_NUMBER = '+19195554321';
+export const BW_VOICE_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345';
+export const BW_MESSAGING_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345';
+export const BASE_CALLBACK_URL = 'https://example.com';