You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
changed the title [-]Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a `lock{}` around it.[/-][+]Thread-Safety Issues[/+]on Dec 1, 2020
Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a lock{} around it.
Maybe I can help out. Are you worried about adding locks? If not, I can go through and analyze the multithreaded stuff so it's all thread-safe with locks.
Activity
[-]Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a `lock{}` around it.[/-][+]Thread-Safety Issues[/+]carlbennett commentedon Dec 1, 2020
Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a
lock{}around it.Originally posted by @carlbennett in #13 (comment)
x3haloed commentedon Nov 27, 2021
Maybe I can help out. Are you worried about adding locks? If not, I can go through and analyze the multithreaded stuff so it's all thread-safe with locks.
carlbennett commentedon Dec 30, 2021
@x3haloed If you want to fork the project and assist by creating a pull request with your work, it would be reviewed and likely welcomed.