Repository navigation
Conversation
…tion
rocm-xio 5c3bc93 ("update tile API") takes (dst, src) for put, put_signal and wait_flag_then_put,
removes sdma_ep.Tile, and takes raw tile arguments with widths and strides in elements scaled by
data_size. Both conventions accept the same integer arguments for the linear calls, so a mismatch
between the pin and the caller reverses the copy without an error.
Moves the [sdma] extra to 5c3bc93 and ports Iris.put, put_tile and put_tiles to it. The host
put_tile/put_tiles signatures change from Tile objects (bytes) to raw arguments (elements); nothing
in the repository called them. The method changes are those of the fused-op work in ROCm#496, applied
here so the pin can move before the triggered-plan work builds on it.
Adds host-only tests that the destination is passed before the source and that the tile calls take
raw arguments; they fail against the previous host methods.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency fix; breaking change to two public methods. rocm-xio 5c3bc93 takes (dst, src) for put, put_signal and wait_flag_then_put, drops sdma_ep.Tile and takes raw tile arguments. Both conventions accept the same integers for the linear calls, so a mismatch reverses the copy silently. Iris.put, put_tile and put_tiles are ported (the method changes are those of ROCm#496 by David Sidler, applied so the pin can move first); the host put_tile/put_tiles signatures change from Tile objects (bytes) to raw arguments (elements). Nothing in the repository called them. No speedup is claimed.
Verified (2 ranks, one host): 43 tests passed; ruff clean. Not run: the Sphinx build, full CI.
🤖 Generated with Claude Code