Repository navigation
Correctly grab pbs version instead of relying on default - #113
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
0 open findings
What changed in this PR
Updates cluster initialization to select the PBS package using the configured pbspro.version instead of a hard-coded default.
Changes:
- Centralizes shared constants in
constants.sh. - Updates scripts to source the new constants file.
- Uses the configured PBS version when constructing package names.
| File | Description |
|---|---|
specs/default/cluster-init/roles/server-install.sh |
Sources shared constants. |
specs/default/cluster-init/files/utils.sh |
Selects packages using the configured PBS version. |
specs/default/cluster-init/files/hwlocs-install.sh |
Sources shared constants. |
specs/default/cluster-init/files/constants.sh |
Defines shared project constants. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ryanhamel
reviewed
Oct 15, 2026
ryanhamel
approved these changes
Oct 15, 2026
Jelena Gvero (jgvero32)
force-pushed
the
jelena/fix-version-bug
branch
from
October 15, 2026 21:19
523a9e1 to
3aead78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.