Repository navigation
test: replace statusreturner with local HTTP fixtures - #666
Merged
Aasav Badera (aasavbadera) merged 3 commits intoNov 16, 2026
Merged
Aasav Badera (aasavbadera) merged 3 commits into
Aasav Badera (aasavbadera) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test server’s default polling interval adds roughly four seconds of idle teardown time across the eight redirect cases.
1 open issue
What changed in this PR
Moves redirect regression coverage into the client unit suites, replacing the external statusreturner service and Azure credentials with local HTTP fixtures. Production code remains unchanged.
Changes:
- Adds a shared loopback fixture for 301, 302, 307, and 308 responses, with cleanup and restored cache/environment state.
- Adds synchronous and asynchronous checks that redirects are rejected and only the query endpoint is requested.
- Removes external-service E2E cases, obsolete skipped tests, and unused imports.
| File | Description |
|---|---|
azure-kusto-data/tests/test_kusto_client.py |
Adds synchronous redirect regression coverage. |
azure-kusto-data/tests/test_e2e_data.py |
Removes external redirect tests and obsolete cloud cases. |
azure-kusto-data/tests/conftest.py |
Provides the shared local HTTP server fixture. |
azure-kusto-data/tests/aio/test_kusto_client.py |
Adds matching asynchronous redirect coverage. |
Review effort: Max
Share a local redirect server between synchronous and asynchronous client tests, use dummy credentials, and remove live Function App E2E references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40145fed-85f7-45a5-814a-2beea3c6a507
Aasav Badera (aasavbadera)
force-pushed
the
aasavbadera/replace-statusreturner-with-local-fixtures
branch
from
November 16, 2026 06:55
b886fee to
3994843
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Restore cache state between tests and make unauthorized authentication deterministic without external HTTP. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: da942e81-4999-4a78-94ff-6703369ade85
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues in the test-only changes that replace service-dependent redirect checks with local fixtures and improve test isolation.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
Tanmaya Panda (tanmaya-panda1)
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added
Changed
Fixed
statusreturnercalls, obsolete skipped cloud-path/404 cases, their trusted-host setup, and imports used only by those cases.Validation
basedpyrighton the changed files, with no new diagnostics; the original repository baseline was preserved.git diff --check; no remaining trackedstatusreturnerreferences.Using the local virtual environment:
The existing
uv.lockrecords workspace version 6.0.3 while the manifests declare 6.0.4, so the normal--lockedsync fails before testing. Validation restored locked external dependencies and installed the editable SDKs with their declared requirements;uv pip checkpassed. The stale lockfile was left unchanged. Live Azure E2E tests were not run.Replaces #661 to move the source branch from the fork to this repository. The source commit and code changes are unchanged.