Repository navigation
AUS-1015: Release 2.0.0-preview.3: strong-named assemblies and the error-handler change - #174
Merged
Merged
Conversation
…hrown exception Release 2.0.0-preview.3. One key, AustinHarris.JsonRpc.snk at the repository root, signs the four packages and the two friend assemblies (the test project and the Micro benchmark); the InternalsVisibleTo entries carry its public key. Public key token e6819c02cf4aec44. MapException no longer replaces an exception that has an InnerException with that inner exception, and no longer promotes an inner JsonRpcException. UnwrapInvocation strips only a TargetInvocationException and a single-inner AggregateException, on the synchronous and asynchronous paths alike; BindingFailure follows the same rule. The async-only unwrap and mapper are folded into it.
…, notification and conversion paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
2.0.0-preview.3with the two incompatible changes adopted by the API usability review (Linear AUS-1015, decisions 1 and 2 of #173). Merging publishes the four packages through the master workflow.Strong-named assemblies.
AustinHarris.JsonRpc.snkat the repository root signs the four packages and the two friend assemblies (the test project and the Micro benchmark); theInternalsVisibleToentries name its public key. Public key tokene6819c02cf4aec44. The key stays the same from here on, since changing it changes the assembly identity. Checked: a strong-named consumer withTreatWarningsAsErrorsreferencing the preview.3 packages onnetstandard2.0andnet10.0builds with no CS8002.The error handler receives the thrown exception.
MapExceptionused to replace an exception that had anInnerExceptionwith that inner exception and to promote an innerJsonRpcException, so a handler saw the cause instead of the error and an authored outer error lost its message. NowUnwrapInvocationstrips only aTargetInvocationExceptionand a single-innerAggregateException, on the synchronous and asynchronous paths alike (the async-only unwrap and mapper are folded into it), andBindingFailurefollows the same rule.ErrorHandlerExceptionTestscovers both paths: outer exception with its cause, innerJsonRpcExceptionnot promoted, authored exception as thrown, reflection and aggregate wrappers stripped, several-inner aggregate kept whole, and the wire with details on. One existing test that encoded the old substitution now expects the three-level chain.Also: version bump to
preview.3in the four projects with release notes, CHANGELOG entries, README (version, signing note, the unwrapping rule in Errors).Tests: 1234 passed on
net8.0and onnet10.0.