Repository navigation
The two symbols this file needs come from public headers now - #4
Merged
Merged
Conversation
mruby made mrb_str_byte_subseq() public in d7bf6bcb: it left internal.h, which is for the callers inside the mruby tree, and it is in mruby/string.h with MRB_API. This file already included that header. MRB_PRESYM_MAX is the second one, and it moved the other way on the same day. f9fc1ff numbers presyms by layer, and it took the count out of presym/id.h - which mruby/presym.h includes, so every gem could read it - into presym/table.h. Tag 39 names a symbol by its presym number when it has one, so this file needs the count, and it now asks the table header for it. That include carries the guard mruby/presym.h and src/symbol.c both use. The build preprocesses every source to find the symbol literals in it, and writes these headers from what it finds, so during that pass the header does not exist yet. Without the guard the build cannot bootstrap: the header is a prerequisite of the pass that writes it. internal.h is gone from this gem. Tests: rake test against mruby master 662ba51, on a clean tree. 3225 total, 3201 OK, 0 KO, 0 crashes, 24 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mruby made mrb_str_byte_subseq() public in d7bf6bcb: it left internal.h, which is for the callers inside the mruby tree, and it is in mruby/string.h with MRB_API. This file already included that header.
MRB_PRESYM_MAX is the second one, and it moved the other way on the same day. f9fc1ff numbers presyms by layer, and it took the count out of presym/id.h - which mruby/presym.h includes, so every gem could read it - into presym/table.h. Tag 39 names a symbol by its presym number when it has one, so this file needs the count, and it now asks the table header for it.
That include carries the guard mruby/presym.h and src/symbol.c both use. The build preprocesses every source to find the symbol literals in it, and writes these headers from what it finds, so during that pass the header does not exist yet. Without the guard the build cannot bootstrap: the header is a prerequisite of the pass that writes it.
internal.h is gone from this gem.
Tests: rake test against mruby master 662ba51, on a clean tree. 3225 total, 3201 OK, 0 KO, 0 crashes, 24 skipped.