Repository navigation
Build against both names of the Bignum byte entries - #2
Merged
Merged
Conversation
mruby renamed two entries on 2026-09-06 (mruby/mruby 053056f): mrb_bint_from_bytes is now mrb_bint_new_bytes, and mrb_bint_size is now mrb_bint_bytes_size. This gem calls both, so it stops building against mruby master with "implicit declaration of function". The preprocessor cannot test for a name, so mrbgem.rake reads include/mruby/internal.h and defines MRB_CBOR_BINT_NEW_BYTES when the new names are there. src/mrb_cbor.c calls one name behind that define and builds against an old checkout as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Asmod4n
pushed a commit
to Asmod4n/webmachine-mruby
that referenced
this pull request
Sep 6, 2026
matz added mrb_vm_interrupt to mruby master (a9151d77). It reads one volatile flag at a send and at the four jumps, so a loop or a recursion is stopped while straight-line code carries neither the branch nor the bytes. The read sits behind mrb_unlikely, which gives gcc the cold edges it needs: mrb_vm_exec went from 67008 to 39060 bytes. That answers what patches/mruby-task-scheduler-disable.patch was for, so the patch, its README, the header probe in mrbgem.rake, and the call in run_guarded all go. mruby/ is on master now, not on the fork branch. One upstream rename had to be met on the way: mruby-cbor calls mrb_bint_from_bytes and mrb_bint_size, which are mrb_bint_new_bytes and mrb_bint_bytes_size since 053056f. Asmod4n/mruby-cbor#2 carries the fix; without it the build stops at mrb_cbor.c. Debug build and suite: 2952 core, 0 KO; 379 bintests, 0 KO. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mruby renamed two entries on 2026-09-06 (mruby/mruby 053056f):
mrb_bint_from_bytesis nowmrb_bint_new_bytesmrb_bint_sizeis nowmrb_bint_bytes_sizeThis gem calls both, so it stops building against mruby master:
The preprocessor cannot test for a name, so
mrbgem.rakereadsinclude/mruby/internal.hand definesMRB_CBOR_BINT_NEW_BYTESwhen the new names are there.src/mrb_cbor.ccalls one name behind that define, so an old checkout builds as well.Found while moving webmachine-mruby to mruby master. The debug build is green with this change.