Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last open item in #72: OSD params are left out of the minimal parameter output unless selected. Following your suggestion there, there is one checkbox for the top level
OSD_*params and one per screen:OSD1_*toOSD4_*, and the param screensOSD5_*andOSD6_*.There are too many OSD params to list by name, so the minimal param lists now also accept a prefix ending in
*. Existing exact-name lists behave as before.Checked on a log with OSD params: main's minimal file has 196 params including 38 OSD. With this change it has 158 and no OSD params, ticking Screen 1 adds its 36, and screens with no params are disabled like the other groups.