Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259, following your diagnosis there: with
LOG_DARM_RATEMAXset, rawGYRsamples logged while disarmed are rate limited, and the loader's batch sample rate no longer matches the data.Reproduced in SITL (
LOG_DISARMED 1,LOG_DARM_RATEMAX 10,INS_RAW_LOG_OPT 1, raw IMU logging on, takeoff, hover, land). GYR runs at ~25 Hz disarmed and 1000 Hz armed. The step from 25 Hz to 1000 Hz isn't a gap, so the whole log becomes one batch with a mean rate of 793.5 Hz, and every frequency is scaled by 0.79 (spectrum ends at 397 Hz). If a gap does split off a disarmed first batch,run_batch_ffttakes its rate fromdata_set[0], which gives the very low rate and the oversized spectrogram from the issue.When
LOG_DARM_RATEMAX > 0and the log hasARMmessages, raw samples logged while disarmed are dropped before batching. The gap left behind splits the armed sections as before. Logs withoutLOG_DARM_RATEMAX, or with no armed data, take the existing path unchanged.I don't have the log from the issue, so it would be good to check it against that one.