Repository navigation
Conversation
ArduPilot now supports a third harmonic notch, and a fourth on some boards (ArduPilot/ardupilot#30246). Add INS_HNTC3_* and INS_HNTC4_* to the notch parameters, their filters and plot tracking lines, and the logged notch frequencies for notches 3 and 4. The third and fourth notch inputs and show options are only shown if the log, or a loaded parameter file, has those parameters. Fixes ArduPilot#252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252.
ArduPilot now supports a third harmonic notch, and a fourth on some boards (ArduPilot/ardupilot#30246). This adds
INS_HNTC3_*andINS_HNTC4_*to FilterReview: their filters in the estimated post-filter spectrum, the tracking lines on the FFT plot and spectrogram, and the logged notch frequencies.The third and fourth notch inputs and show options only appear if the log, or a loaded parameter file, has those parameters, so the page is unchanged for two-notch firmware.
Testing:
The Filter Tool link still only carries notches 1 and 2, as the Filter Tool supports two.