Skip to content

SysID: fix ESLint problems - #358

Open
j-w9 wants to merge 4 commits into
ArduPilot:mainfrom
j-w9:lint-SysID
Open

j-w9 wants to merge 4 commits into
ArduPilot:mainfrom
j-w9:lint-SysID

Conversation

@j-w9

@j-w9 j-w9 commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Fixes ESLint problems in SysID and removes the fixed entries from eslint-suppressions.json. None of the changes alter behaviour.

  • Declare variables that were implicitly global. Each was assigned without let/var, creating a global, but is only used within the function (or loop) that assigns it, and is not used by any other script on the page, so let does not change behaviour.
  • Declare the matrix-filling variables in each function. rows, cols, cellSelector and inputElement were implicit globals shared by setMatrixA, setMatrixB, setH0 and setH1. Each function assigns them before reading them and none calls another, so declaring them locally does not change behaviour.
  • Remove variables that are assigned but never read. temp_data in the compensation loops was an implicit global that nothing read; declaring it would only make it an unused local, so it is removed.

One commit per kind of fix; npm run lint passes.

j-w9 added 4 commits October 13, 2026 22:30
Each was assigned without let/var, creating a global, but is only used
within the function (or loop) that assigns it, and is not used by any
other script on the page, so let does not change behaviour.
rows, cols, cellSelector and inputElement were implicit globals shared
by setMatrixA, setMatrixB, setH0 and setH1. Each function assigns them
before reading them and none calls another, so declaring them locally
does not change behaviour.
dbl and triple in the notch filters, and temp_data in SysID's
compensation loops, were implicit globals that nothing read; declaring
them only made them unused locals. Drop them and prune their
suppressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant