Repository navigation
Conversation
Each was assigned without let/var, creating a global, but is only used within the function (or loop) that assigns it, and is not used by any other script on the page, so let does not change behaviour.
rows, cols, cellSelector and inputElement were implicit globals shared by setMatrixA, setMatrixB, setH0 and setH1. Each function assigns them before reading them and none calls another, so declaring them locally does not change behaviour.
dbl and triple in the notch filters, and temp_data in SysID's compensation loops, were implicit globals that nothing read; declaring them only made them unused locals. Drop them and prune their suppressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ESLint problems in SysID and removes the fixed entries from
eslint-suppressions.json. None of the changes alter behaviour.temp_datain the compensation loops was an implicit global that nothing read; declaring it would only make it an unused local, so it is removed.One commit per kind of fix;
npm run lintpasses.