Skip to content

fix(openapi): skip OPTIONS operations when generating tools #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(openapi): skip OPTIONS operations when generating tools #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/openapi/converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (c *Converter) Convert(specData []byte) (*config.MCPConfig, error) {
for path, pathItem := range doc.Paths.Map() {
// Create a tool for each HTTP method
for method, operation := range pathItem.Operations() {
if method == "options" {
if strings.EqualFold(method, "options") {
continue // Skip CORS options
}

Expand Down
1 change: 1 addition & 0 deletions pkg/openapi/converter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@ func TestConverter_Convert_SkipOptionsAndKeepSummaryAsDescription(t *testing.T)

cfg, err := converter.ConvertFromJSON([]byte(spec))
assert.NoError(t, err)
assert.Len(t, cfg.Tools, 1)
// Ensure GET tool is present with summary used as description
found := false
for _, tcfg := range cfg.Tools {
Expand Down