Repository navigation
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
On a beam, getTransformationPlan skips the completed-step apply because the beamed source is already transformed. Unit tests generated after Local Build Verification are new on top of it, so finished Merge Tests steps under the loaded repo's steps (beamScopeStepIds) are now downloaded and applied, once each. Nothing changes until a beam card has a Merge Tests step.
…m card
Unit test steps sit under the card where the run was started. A web transform's own
run is under the repo's transform card and its tests are already in the beamed zip,
so applying its Merge Tests diff again would duplicate them if the IDE's scope covers
that card. Only Merge Tests steps under a beam card ("<repo> (beamed)") are applied;
each run started from the IDE is applied once, in plan order.
cslong
force-pushed
the
dev/longachr/ut-beam-apply-merged-tests
branch
from
October 27, 2026 19:44
25ec32a to
79d2d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Beam to IDE job,
getTransformationPlanskips the completed-step apply pass, because the beamed source is already transformed. Unit tests generated after Local Build Verification on a beam are new on top of that source, so their Merge Tests diff is never applied to the local solution.Solution
In the beam branch of
getTransformationPlan, apply finished "Merge Tests" steps at or below the loaded repo's steps (beamScopeStepIds, which the IDE already sends), in plan order, once each:checkpoints-applied.jsonbookkeeping apply; already-applied steps are skipped, so it's safe on every poll.<repo> (beamed)by the web orchestrator) are applied. Unit test steps sit under the card where the run was started: a web transform's own run is under the repo's transform card, and its tests are already in the beamed zip, so it is never applied again even if the scope covers that card. Each run started from the IDE adds its own Merge Tests step and is applied once.No behaviour change until a beam plan contains a Merge Tests step.
Testing: new unit tests in
atxTransformHandler.test.ts("getTransformationPlan on a beam: merged unit tests"): only the loaded repo's finished step is applied; nothing without a scope or solution path; already-applied and unfinished steps are skipped; a failure is reported; a plan with no unit test step does nothing; the web transform's Merge Tests is skipped when the scope includes its card; two runs on the beam card are applied once each, in plan order.npx ts-mochaon the netTransform tests: 496 passing;atxTransformHandler.test.tswith the beam-card guard: 329 passing; no new eslint or tsc errors; prettier clean.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.