Repository navigation
[Backport] fix: avoid crash when links to components change in dynamic texts - #4391
Merged
Merged
Conversation
) Links made with linkToComponent are parsed from text without stable keys, so React reused a LinkToPotentialNode for a link with another target when a link was removed from the middle of a list. useIsHidden throws when its component id changes. Key the inner component on the target so a new target mounts fresh.
github-actions
Bot
added
automated
backport-ignore
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
phlipsterit
enabled auto-merge (rebase)
October 22, 2026 12:44
phlipsterit
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4386
This is an automated backport of PR #4386 to the
release/v4.35release branch.Original PR
Changes
Cherry-picked the merge commit from the original PR onto the release branch.
🤖 This backport PR was created automatically by the Auto Backport workflow.