Repository navigation
download: skip chown of embedded_backup_disk for regular backups - #1654
Merged
Merged
Conversation
downloadEpilogue chowned <embedded_backup_disk path>/<backup> for every disk marked IsBackup. IsBackup is set by disk name from config, regardless of the kind of the downloaded backup, so a regular backup downloaded with use_embedded_backup_restore=true + embedded_backup_disk configured failed after the data was fetched with "Chown backup disk: lstat ...: no such file or directory" (only as root, Chown is a no-op otherwise). Guard the loop with b.isEmbedded, which is taken from the backup tags. Fixes #1653 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 40843672532Coverage increased (+0.003%) to 70.571%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions22 previously-covered lines in 7 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653
downloadEpiloguechowned<embedded_backup_disk path>/<backup>for every disk withIsBackup.IsBackupis assigned inGetDiskspurely by matching the disk name toclickhouse.embedded_backup_disk, independent of whether the downloaded backup is embedded. So a regular backup downloaded withuse_embedded_backup_restore: true+embedded_backup_diskconfigured failed after the data was fetched:(only when running as root,
Chownis a no-op otherwise). The loop is now guarded byb.isEmbedded, which is derived from the backup tags, same as the.backupdownload block just above.Test:
TestDownloadRegularBackupWithEmbeddedBackupDiskcreates a regular backup, then downloads and restores it withCLICKHOUSE_USE_EMBEDDED_BACKUP_RESTORE=true CLICKHOUSE_EMBEDDED_BACKUP_DISK=backups_s3. Fails on master with the error above, passes with the fix.🤖 Generated with Claude Code