Skip to content

[PWGUD] update upcRhoPrimeAnalysis - RD and MC - #18115

Merged
amatyja merged 2 commits into
AliceO2Group:masterfrom
CesarOmarRA:master
Oct 1, 2026
Merged

amatyja merged 2 commits into
AliceO2Group:masterfrom
CesarOmarRA:master

Conversation

@CesarOmarRA

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 28 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title PWGUD: update upcRhoPrimeAnalysis - RD and MC [PWGUD] update upcRhoPrimeAnalysis - RD and MC Sep 30, 2026
@CesarOmarRA
CesarOmarRA force-pushed the master branch 2 times, most recently from 6af3fcc to 14cab28 Compare September 30, 2026 08:24
rolavick
rolavick previously approved these changes Sep 30, 2026
@rolavick
rolavick enabled auto-merge (squash) September 30, 2026 11:12
auto-merge was automatically disabled September 30, 2026 13:50

Head branch was pushed to by a user without write access

rolavick
rolavick previously approved these changes Sep 30, 2026
@rolavick
rolavick enabled auto-merge (squash) September 30, 2026 14:03
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 14cab28 at 2026-09-30 16:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 25 errors and 34 warnings.'
Found 25 errors and 34 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/e2bf018d50186f4bbaf36ad11ef2ff8c9a2a9b3e/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:24:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:25:1: error: included header TH1F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:26:1: error: included header TH2F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:145:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:150:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:183:3: error: no header providing "o2::framework::HistogramRegistry" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:186:48: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:275:53: error: no header providing "std::sqrt" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:279:14: error: no header providing "std::abs" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:281:26: error: no header providing "std::log" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:289:19: error: no header providing "std::atan2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:315:10: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:324:10: error: the variable 'mother' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:345:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:348:31: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:348:36: error: no header providing "HIST" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:395:40: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:637:5: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:719:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:411:23: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:693:10: error: the variable 'mother' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:885:19: error: comparison of integers of different signs: 'uint64_t' (aka 'unsigned long') and 'int64_t' (aka 'long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:888:37: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:900:19: error: comparison of integers of different signs: 'uint64_t' (aka 'unsigned long') and 'int64_t' (aka 'long') [clang-diagnostic-sign-compare,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:903:37: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-compare,-warnings-as-errors]
++ [[ 34 -gt 0 ]]
++ cat /sw/BUILD/e2bf018d50186f4bbaf36ad11ef2ff8c9a2a9b3e/O2Physics-code-check/warnings.txt
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:103:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:104:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:105:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:106:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:107:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:108:56: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:428:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:430:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:432:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:751:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:752:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:753:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:754:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:755:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:756:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

auto-merge was automatically disabled September 30, 2026 14:18

Head branch was pushed to by a user without write access

@CesarOmarRA
CesarOmarRA force-pushed the master branch 2 times, most recently from 4be866a to 5182d7e Compare September 30, 2026 14:23
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 14cab28 at 2026-09-30 16:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:885:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:888:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:900:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:903:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:885:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:888:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:900:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:903:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 14cab28 at 2026-09-30 17:14:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:885:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:888:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:900:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:903:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:885:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:888:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:900:19: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/upcVmRof.cxx:903:37: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'uint64_t' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cc68817 at 2026-09-30 22:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 34 warnings.'
Found 1 errors and 34 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/ac0a65fc82b8642c30a67c65ccf1bbec7a585979/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:27:1: error: included header OutputObjHeader.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 34 -gt 0 ]]
++ cat /sw/BUILD/ac0a65fc82b8642c30a67c65ccf1bbec7a585979/O2Physics-code-check/warnings.txt
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:112:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:113:42: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:114:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:115:44: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:116:46: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:117:56: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:437:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:439:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:441:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:760:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:761:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:762:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:763:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:764:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:765:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:886:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:887:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:888:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:889:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:890:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoPrimeAnalysis.cxx:891:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcVmRof.cxx:346:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcVmRof.cxx:358:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcVmRof.cxx:369:21: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcVmRof.cxx:373:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcVmRof.cxx:891:13: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGUD/Tasks/upcVmRof.cxx:906:13: warning: do not use 'else' after 'break' [readability-else-after-return]
PWGUD/Tasks/upcVmRof.cxx:980:17: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/Tasks/upcVmRof.cxx:999:17: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGUD/Tasks/upcVmRof.cxx:1045:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcVmRof.cxx:1101:10: warning: variable 'isTwoBody' is not initialized [cppcoreguidelines-init-variables]
PWGUD/Tasks/upcVmRof.cxx:1101:21: warning: variable 'isFourBody' is not initialized [cppcoreguidelines-init-variables]
PWGUD/Tasks/upcVmRof.cxx:1118:10: warning: variable 'isTwoBody' is not initialized [cppcoreguidelines-init-variables]
PWGUD/Tasks/upcVmRof.cxx:1118:21: warning: variable 'isFourBody' is not initialized [cppcoreguidelines-init-variables]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for cc68817 at 2026-09-30 22:21:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for bf83d7e at 2026-10-01 00:07:

No log files found

Full log here.

@amatyja
amatyja merged commit be9230c into AliceO2Group:master Oct 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants