[PWGCF] Fix cpplint errors

PWGCF/Core/PWGCFCoreLinkDef.h

@@ -8,8 +8,8 @@
 // In applying this license CERN does not waive the privileges and immunities
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
-#ifndef PWGCF_CORE_PWGCFCORELINKDEF_H_
-#define PWGCF_CORE_PWGCFCORELINKDEF_H_
+
+// NOLINT(build/header_guard)
 
 #pragma link off all globals;
 #pragma link off all classes;
@@ -23,4 +23,3 @@
 #pragma link C++ class o2::analysis::TrackSelectionPIDCfg + ;
 #pragma link C++ class o2::analysis::SimpleInclusiveCut + ;
 #pragma link C++ class CorrelationContainer + ;
-#endif // PWGCF_CORE_PWGCFCORELINKDEF_H_

PWGCF/EbyEFluctuations/Tasks/NetProtonCumulants.cxx

@@ -38,6 +38,7 @@
 #include <cmath>
 #include <cstdint>
 #include <memory>
+#include <string>
 #include <vector>
 
 #include <math.h>
@@ -69,7 +70,7 @@ struct NetProtonCumulants_Table_QA {
 
   // Filter command***********
   Filter collisionFilter = nabs(aod::collision::posZ) < cfgCutVertex;
-  Filter trackFilter = (nabs(aod::track::eta) < 0.8f) && (aod::track::pt > cfgCutPtLower) && (aod::track::pt < 5.0f) && ((requireGlobalTrackInFilter()) || (aod::track::isGlobalTrackSDD == (uint8_t) true)) && (aod::track::tpcChi2NCl < cfgCutTpcChi2NCl);
+  Filter trackFilter = (nabs(aod::track::eta) < 0.8f) && (aod::track::pt > cfgCutPtLower) && (aod::track::pt < 5.0f) && ((requireGlobalTrackInFilter()) || (aod::track::isGlobalTrackSDD == (uint8_t)true)) && (aod::track::tpcChi2NCl < cfgCutTpcChi2NCl);
 
   // Connect to ccdb
   Service<ccdb::BasicCCDBManager> ccdb;

PWGCF/FemtoWorld/Core/FemtoWorldTrackSelection.h

@@ -96,7 +96,7 @@ class FemtoWorldTrackSelection : public FemtoWorldObjectSelection<float, femtoWo
                                dcaXYMax(-9999999.),
                                dcaZMax(-9999999.),
                                dcaMin(9999999.),
-                               nSigmaPIDMax(9999999.) {};
+                               nSigmaPIDMax(9999999.) {}
 
   /// Initializes histograms for the task
   /// \tparam part Type of the particle for proper naming of the folders for QA

PWGCF/FemtoWorld/Core/FemtoWorldV0Selection.h

@@ -88,7 +88,7 @@ class FemtoWorldV0Selection : public FemtoWorldObjectSelection<float, femtoWorld
                             fInvMassUpLimit(1.3),
                             fRejectKaon(false),
                             fInvMassKaonLowLimit(0.48),
-                            fInvMassKaonUpLimit(0.515) {};
+                            fInvMassKaonUpLimit(0.515) {}
   /// Initializes histograms for the task
   template <o2::aod::femtoworldparticle::ParticleType part, o2::aod::femtoworldparticle::ParticleType daugh, typename cutContainerType>
   void init(o2::framework::HistogramRegistry* registry);
@@ -472,9 +472,7 @@ std::array<cutContainerType, 5> FemtoWorldV0Selection::getCutContainer(C const&
     sign = -1.;
   } else if (abs(nSigmaPrPos) < nSigmaPIDMax && abs(nSigmaPiNeg) < nSigmaPIDMax && diffAntiLambda < diffLambda) {
     sign = 1.;
-  }
-  // if it happens that none of these are true, ignore the invariant mass
-  else {
+  } else { // if it happens that none of these are true, ignore the invariant mass
     if (abs(nSigmaPrNeg) < nSigmaPIDMax && abs(nSigmaPiPos) < nSigmaPIDMax) {
       sign = -1.;
     } else if (abs(nSigmaPrPos) < nSigmaPIDMax && abs(nSigmaPiNeg) < nSigmaPIDMax) {

PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx

@@ -37,6 +37,8 @@
 #include <Math/Vector4D.h>
 #include <TMath.h>
 
+#include <vector>
+
 using namespace o2;
 using namespace o2::analysis::femtoWorld;
 using namespace o2::framework;

PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx

@@ -35,9 +35,12 @@
 #include <Framework/runDataProcessing.h>
 #include <ReconstructionDataFormats/Track.h>
 
-#include <Math/Vector4D.h>
+#include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h)
+#include <Math/Vector4Dfwd.h>
 #include <TMath.h>
 
+#include <vector>
+
 using namespace o2;
 using namespace o2::analysis::femtoWorld;
 using namespace o2::framework;

PWGCF/FemtoWorld/Tasks/femtoWorldPairTaskTrackTrack.cxx

@@ -214,32 +214,39 @@ struct femtoWorldPairTaskTrackTrack {
       if (mom > 0.5) {
         //        if (TMath::Hypot( nsigmaTOFP, nsigmaTPCP )/TMath::Sqrt(2) < 3.0)
         if (mom < 2.0) {
-          if (TMath::Hypot(nsigmaTOFK, nsigmaTPCK) < fNsigma)
+          if (TMath::Hypot(nsigmaTOFK, nsigmaTPCK) < fNsigma) {
             return true;
-        } else if (TMath::Hypot(nsigmaTOFK, nsigmaTPCK) < fNsigma2)
+          }
+        } else if (TMath::Hypot(nsigmaTOFK, nsigmaTPCK) < fNsigma2) {
           return true;
+        }
       } else {
-        if (TMath::Abs(nsigmaTPCK) < fNsigma)
+        if (TMath::Abs(nsigmaTPCK) < fNsigma) {
           return true;
+        }
       }
     } else {
-
       if (mom < 0.4) {
         if (nsigmaTOFK < -999.) {
-          if (TMath::Abs(nsigmaTPCK) < 2.0)
+          if (TMath::Abs(nsigmaTPCK) < 2.0) {
             return true;
-        } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0)
+          }
+        } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0) {
           return true;
+        }
       } else if (mom >= 0.4 && mom <= 0.6) {
         if (nsigmaTOFK < -999.) {
-          if (TMath::Abs(nsigmaTPCK) < 2.0)
+          if (TMath::Abs(nsigmaTPCK) < 2.0) {
             return true;
-        } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0)
+          }
+        } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0) {
           return true;
+        }
       } else if (nsigmaTOFK < -999.) {
         return false;
-      } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0)
+      } else if (TMath::Abs(nsigmaTOFK) < 3.0 && TMath::Abs(nsigmaTPCK) < 3.0) {
         return true;
+      }
     }
     return false;
   }

PWGCF/GenericFramework/Core/GenericFrameworkLinkDef.h

@@ -9,8 +9,7 @@
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
 
-#ifndef PWGCF_GENERICFRAMEWORK_CORE_GENERICFRAMEWORKLINKDEF_H_
-#define PWGCF_GENERICFRAMEWORK_CORE_GENERICFRAMEWORKLINKDEF_H_
+// NOLINT(build/header_guard)
 
 #pragma link off all globals;
 #pragma link off all classes;
@@ -28,5 +27,3 @@
 #pragma link C++ class o2::analysis::genericframework::GFWBinningCuts + ;
 #pragma link C++ class o2::analysis::genericframework::GFWRegions + ;
 #pragma link C++ class o2::analysis::genericframework::GFWCorrConfigs + ;
-
-#endif // PWGCF_GENERICFRAMEWORK_CORE_GENERICFRAMEWORKLINKDEF_H_

PWGCF/JCorran/Core/JCORRANLinkDef.h

@@ -9,8 +9,7 @@
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
 
-#ifndef PWGCF_JCORRAN_CORE_JCORRANLINKDEF_H_
-#define PWGCF_JCORRAN_CORE_JCORRANLINKDEF_H_
+// NOLINT(build/header_guard)
 
 #pragma link off all globals;
 #pragma link off all classes;
@@ -22,5 +21,3 @@
 #pragma link C++ class FlowJSPCAnalysis + ;
 #pragma link C++ class FlowJSPCObservables + ;
 #pragma link C++ class JEPFlowAnalysis + ;
-
-#endif // PWGCF_JCORRAN_CORE_JCORRANLINKDEF_H_

PWGCF/TwoParticleCorrelations/Core/EventSelectionFilterAndAnalysis.cxx

@@ -474,8 +474,6 @@ void EventSelectionFilterAndAnalysis::StoreArmedMask()
   }
   mOptArmedMask.push_back(optMask);
   optMask = 0UL;
-  if (mTriggerSelection != nullptr) {
-  }
   if (mZVertex != nullptr) {
     armedBrick(mZVertex);
   }

PWGCF/TwoParticleCorrelations/Core/EventSelectionFilterAndAnalysis.h

@@ -111,7 +111,7 @@ class EventSelectionFilterAndAnalysis : public SelectionFilterAndAnalysis
   template <typename CollisionToFilter, typename AssociatedTracks>
   void StoreMultiplicities(CollisionToFilter const&, AssociatedTracks const&);
   int CalculateMaskLength() override;
-  virtual void StoreArmedMask() override;
+  void StoreArmedMask() override;
 
   std::vector<CutBrick<float>*> mBFieldSelection; //! the magnetic field selection cuts
   MultiplicityBrick* mMultiplicityClasses;        //! the multiplicity classes cuts
@@ -231,8 +231,6 @@ inline uint64_t EventSelectionFilterAndAnalysis::Filter(CollisionToFilter const&
     bool acc = mMultiplicityClasses->ComplexBrickHelper::Filter(selectedMask, bit);
     acceptcollision = acceptcollision && acc;
   }
-  if (mTriggerSelection != nullptr) {
-  }
   if (mZVertex != nullptr) {
     bool acc = filterBrickValue(selectedMask, bit, mZVertex, col.posZ());
     acceptcollision = acceptcollision && acc;

PWGCF/TwoParticleCorrelations/Core/PIDSelectionFilterAndAnalysis.h

@@ -98,7 +98,7 @@ class PIDSelectionFilterAndAnalysis : public SelectionFilterAndAnalysis
   PIDSelectionFilterAndAnalysis();
   PIDSelectionFilterAndAnalysis(const TString&, selmodes);
   PIDSelectionFilterAndAnalysis(const PIDSelectionConfigurable& pidsel, selmodes mode);
-  virtual ~PIDSelectionFilterAndAnalysis() override;
+  ~PIDSelectionFilterAndAnalysis() override;
 
   void SetPTOF(float ptof) { mPTOF = ptof; }
   void SetRequireTOF(bool requiretof = false) { mRequireTOF = requiretof; }
@@ -133,8 +133,8 @@ class PIDSelectionFilterAndAnalysis : public SelectionFilterAndAnalysis
 
  private:
   void ConstructCutFromString(const TString&);
-  virtual int CalculateMaskLength() override;
-  virtual void StoreArmedMask() override;
+  int CalculateMaskLength() override;
+  void StoreArmedMask() override;
 
   float mPTOF = 0.8f;           ///< the p threshold for cheking TOF information
   bool mRequireTOF = false;     ///< is TOF required