Conversation
This is the first commit of this task. It starts the migration to O2Physics of the event-shape analyses developed in AliPhysics under PWGLF/SPECTRA/MultEvShape (https://github.com/alisw/AliPhysics/tree/master/PWGLF/SPECTRA/MultEvShape). The physics programme carries over; the implementation is written anew for O2Physics as a slim per-collision derived table, with the analysis done on top of it.
|
O2 linter results: ❌ 0 errors, |
c-andrei
marked this pull request as ready for review
September 29, 2026 07:44
c-andrei
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
gbencedi,
lhusova,
maciacco,
mario-krueger,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
September 29, 2026 07:44
maciacco
previously approved these changes
Sep 29, 2026
Collaborator
|
Error while checking build/O2Physics/code-check for 3f44ff5 at 2026-09-30 03:12: Full log here. |
Include Framework/AnalysisHelpers.h directly (misc-include-cleaner), mark meanPt [[nodiscard]], use std::array for the QA-bit order and brace-initialise the PDG service. No change in output.
Author
|
Thanks for the review. I pushed a follow-up commit fixing the code-check findings (direct include of Framework/AnalysisHelpers.h plus three warnings); the output is unchanged. Could you please take another look and re-trigger the tests if needed? |
maciacco
enabled auto-merge (squash)
October 1, 2026 07:45
maciacco
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first commit of this task. It starts the migration to O2Physics of the event-shape analyses developed in AliPhysics under PWGLF/SPECTRA/MultEvShape.
Adds a table producer (o2-analysis-lf-event-shape-coex) that writes per-collision forward/backward sub-event quantities at reconstructed and generator level, plus an MC label table linking the two. It is the first GEP table producer, so it creates PWGLF/TableProducer/GlobalEventProperties (already listed in CODEOWNERS). "Coex" in the names is the internal name of the analysis.