Skip to content

[O2B-1621] Associate eor reasons to user by user id and not name - #2235

Open
graduta wants to merge 3 commits into
feature/O2B-1620/associate-user-tag-by-id-not-namefrom
feature/O2B-1621/associate-eor-reasons-to-user-by-id
Open

graduta wants to merge 3 commits into
feature/O2B-1620/associate-user-tag-by-id-not-namefrom
feature/O2B-1621/associate-eor-reasons-to-user-by-id

Conversation

@graduta

@graduta graduta commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • none

Notable changes for developers:

  • the run use case(used by the HTTP API) is now throwing error if the change of an EOR reason does not contain valid id of an existing user
  • the usecase has been adapted to throw rather than return object with error
  • the run service has also been updated but this as it is used by Kafka and gRPC services for automatic EOR purposes, do not require to have a user id

Changes made to the database:

  • table eor_reason now is associated to user tables by user id

@graduta
graduta requested a review from isaachilly as a code owner October 1, 2026 14:53
@graduta graduta changed the title [O2B-162associate eor reasons to user by [O2B-1621] Associate eor reasons to user by user id and not name Oct 1, 2026
@graduta graduta self-assigned this Oct 1, 2026
@graduta
graduta added this pull request to stack #2236 October 1, 2026 14:55
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (4bd7b9b) to head (d3d9ccb).

Files with missing lines Patch % Lines
...261001100000-eor-reasons-last-edited-by-user-id.js 55.55% 4 Missing ⚠️
lib/public/views/Runs/format/editRunEorReasons.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/format/formatRunEorReason.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/Details/RunPatch.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           feature/O2B-1620/associate-user-tag-by-id-not-name    #2235      +/-   ##
======================================================================================
+ Coverage                                               46.22%   46.23%   +0.01%     
======================================================================================
  Files                                                    1041     1042       +1     
  Lines                                                   17178    17189      +11     
  Branches                                                 3129     3127       -2     
======================================================================================
+ Hits                                                     7941     7948       +7     
- Misses                                                   9237     9241       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant