Skip to content

[O2B-1620] Tags should associate user by id and not name on update - #2234

Open
graduta wants to merge 5 commits into
mainfrom
feature/O2B-1620/associate-user-tag-by-id-not-name
Open

graduta wants to merge 5 commits into
mainfrom
feature/O2B-1620/associate-user-tag-by-id-not-name

Conversation

@graduta

@graduta graduta commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • none

Notable changes for developers:

  • tags endpoint are now returning an object of user that last edited with name only rather than entire entity
  • the TagUseCase has been updated to not be aware of HTTP return status code and instead throw when a critical condition is not met. This in turn makes it easier to transition towards the recommended BKP architecture of high/low level service
  • front-end changes are minimal to update the new structure of returned object

Changes made to the database:

  • tags table now store the association with user table by ID and not name of user

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.22%. Comparing base (f9c05ae) to head (4bd7b9b).

Files with missing lines Patch % Lines
...s/v1/20260930100000-tags-last-edited-by-user-id.js 55.55% 4 Missing ⚠️
lib/public/components/tag/tagDetail.js 0.00% 1 Missing ⚠️
...blic/views/Tags/ActiveColumns/tagsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
+ Coverage   46.17%   46.22%   +0.05%     
==========================================
  Files        1040     1041       +1     
  Lines       17160    17178      +18     
  Branches     3133     3129       -4     
==========================================
+ Hits         7923     7941      +18     
  Misses       9237     9237              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta added this pull request to stack #2236 October 1, 2026 14:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant