Conversation
… parameters in BaseRecoTask
Co-authored-by: Felix Schlepper <f3sch.git@outlook.com>
wpierozak
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
October 1, 2026 09:47
| struct FV0RecoConfig : o2::conf::ConfigurableParamHelper<FV0RecoConfig> { | ||
| double AmplitudeLowerThreshold = 24; // only channels with amplitude higher will participate in calibration and collision time | ||
| double AmplitudeThreholdForMeanTime = 5; // Charge threshold, only above which the time is taken into account in calculating the mean time of all qualifying channels | ||
| double TimeUpperThershold = 1000.0; // only channels with time below will participate in calibration and collision time |
Collaborator
There was a problem hiding this comment.
Typo in "Threshold". Let's correct this so that the configurable parameter name is consistent.
| // or submit itself to any jurisdiction. | ||
|
|
||
| #ifndef ALICEO2_FV0_DIGIT_FILTER_PARAM | ||
| #define ALICEO2_FV0_DIGIT_FILTER_PARAM |
Collaborator
There was a problem hiding this comment.
The header was renamed to FV0RecoConfig.h, but the guard still refers to "FV0_DIGIT_FILTER_PARAM"
Could we rename it, for e.g. ALICEO2_FV0_RECO_CONFIG to avoid name clash ?
| struct FV0RecoConfig : o2::conf::ConfigurableParamHelper<FV0RecoConfig> { | ||
| double AmplitudeLowerThreshold = 24; // only channels with amplitude higher will participate in calibration and collision time | ||
| double AmplitudeThreholdForMeanTime = 5; // Charge threshold, only above which the time is taken into account in calculating the mean time of all qualifying channels | ||
| double TimeUpperThershold = 1000.0; // only channels with time below will participate in calibration and collision time |
Collaborator
There was a problem hiding this comment.
Also, any specific reason to change the type of the 3 parameters to double ?
Earlier it was:
float chargeThrForMeanTime = 5;
float mAmpThresholdForReco = 24;
short mTimeThresholdForReco = 1000;
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved FV0 reconstruction parameters from digitizer configuration structure to dedicated configurable structure and updated reconstruction code to use it.
FV0RecoConfig inherits from ConfigurableParamHelper, so it can be modified by either command-line arguments or object fetched from CCDB.