Use std::abs for floating-point values in TRD and ITS studies - #15874
Merged
Merged
Conversation
This fixes unqualified abs() calls on floats that resolve to the integer abs and truncate. - 11 calls in TRD TrackBasedCalib and ITS studies (Efficiency, AvgClusSize) called int abs(int) on a float. - They now call std::abs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel
requested review from
bazinski,
f3sch,
fprino,
mconcas,
mcoquet642,
shahor02 and
wille10
as code owners
September 30, 2026 14:07
shahor02
approved these changes
Sep 30, 2026
bazinski
approved these changes
Sep 30, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes unqualified abs() calls on floats that resolve to the integer abs and truncate.
Note that this changes the selections in the TRD track-based calibration and in the ITS postprocessing studies: the snp rejection, the barrel-gap exclusion, the DCA windows and the V0 mass windows now cut as written instead of on the truncated integer value.
Assisted by Claude Code.