Use std::threads instead of TBB tasks in the o2-sim hit merger - #15871
Merged
sawenzel merged 1 commit intoSep 30, 2026
Merged
Conversation
This fixes a crash of the o2-sim hit merger at the end of a run. - The concurrent flush of kinematics and detector files used a tbb::task_group and tbb::parallel_for_each. - It runs on a merger IO thread that is created anew for every merge batch. - When such a thread exits, TBB releases its thread pool and can segfault in pthread_detach. - The flush now uses std::threads that are joined before the function returns. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Validated on the GRID with the QED stages of the
The crash disappears with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash of the o2-sim hit merger at the end of a run.