GPUTracking: declare the resolve kernel's shared memory as shared - #15860
Merged
Merged
Conversation
The definitions in GPUTPCGMMergerGPU.cxx qualify smem with GPUsharedref(), and so does every other declaration in the header; this one did not. It makes no difference where GPUsharedref() is empty, but on Metal the declaration then takes a generic reference and the definition a threadgroup one, which are different types.
Member
Author
|
@davidrohr this seems to be a genuine defect which is currently working by accident. |
Collaborator
|
Actually, the GPUsharedref was only needed for OpenCL1.x |
Member
Author
|
I understand it's not actually needed. It does need some reshuffling though. I suggest we attack it once we have something running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definitions in GPUTPCGMMergerGPU.cxx qualify smem with GPUsharedref(), and
so does every other declaration in the header; this one did not. It makes no
difference where GPUsharedref() is empty, but on Metal the declaration then
takes a generic reference and the definition a threadgroup one, which are
different types.