Repository navigation
Remove build.sh, the concatenation build - #2849
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
build.sh, which has not built since step 2 of the conversion (the files it lists moved), and updates the sentence inbuild.jsthat said it would stay until the end of the phase. Nothing calls it:package.jsonbuilds withbun build.js, CI runsyarn build-only, and the parity check builds old commits with the build those commits carry (test/parity/run.js, unchanged).Left as it is, for the maintainer: the
rexreplacedev dependency served only build.sh; dropping it is a lockfile change for a separate commit.Parity on the tip: 0 differences over 77,053 statements against develop at #2798, API identical apart from the 11 allowed; suite 2452 pass, 213 skip, 0 fail; the 8 smokes that run without
--packpass.