Repository navigation
Step 10: Prettier once over the converted modules, with a no-undef pass - #2847
Merged
Merged
Conversation
mathiasrw
force-pushed
the
fix/format-converted
branch
from
October 22, 2026 01:31
f1fbac6 to
497a297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 10 of the ES6 conversion (
context/roadmap-phase-1.md): lint and format. One Prettier commit over every converted module, its hash in.git-blame-ignore-revs, the conversion folders out of.prettierignorein the same commit, and ano-undefpass over the converted files. It also carries the end-of-phase benchmark into ledger row 9, since #2845 merged before the quiet machine came, and the forward merge ofdevelop(#2798), made before the Prettier commit so that git carried the fix into the moved files.The forward merge (35bd5a9):
develophas one commit since 4.21.0, #2798 (044ab07), which changes60createtable.js(19 lines) and94filestorage.js(15 lines) and adds test1846.js. The merge landed both changes insrc/statements/createtable.jsandsrc/storage/filestorage.jswithout a conflict;git diff 98d68eaa 35bd5a99shows nothing else. The suite went from 2447 to 2452 passing. The parity reference moved todevelopat 044ab07, built with its own build.sh (ref-044ab07a;yarn test-paritynames it now): 0 differences, API identical apart from the 11 allowed. Against the old 4.21.0 reference one result differs, the xlsx serial date of test815.js, which is the parity check's fixed clock running ahead by the statements test1846.js adds before it, not #2798.The formatting commit (
fac32eef) runs Prettier with the repository's settings over 84 files in the thirteen conversion folders.src/worker/start.jsandsrc/worker/finish.jsstay ignored by name: they are the head and tail of the worker concatenation, not parsable on their own.src/engine/finish.jsloses its CRLF endings here. Nothing else changes: the suite, the parity check and the smokes are the same before and after, and the bundles differ only in comments and whitespace..git-blame-ignore-revsis new, with that hash; GitHub's blame view reads it on its own, and a clone gets the same withgit config blame.ignoreRevsFile .git-blame-ignore-revs.no-undef over the converted modules, with the browser and Node globals the files use on purpose listed: 20 names resolve to nothing. Eighteen are environment globals the files reach on purpose (
MeteorandMongofor Meteor,LocalFileSystemfor Cordova,globalfor Node,alasqlin the echo, prolog and orientdb plugins, and the two worker fragments that are not modules). Two are latent bugs of 4.21.0, left as they are:renameColumnsinsrc/statements/with.js(#2841) andfsdbidinsrc/storage/filestorage.js(#2846, filed with the ATTACH failure found on the way). The pass is a one-off throughnpx eslint; eslint is not a dependency of the repository.One change to what CI checks, in its own commit (
48a04188), easy to drop:test-format-alllisted{.,src,test}/*.{js,ts,json}, one level deep, so the "Verify code formatting" job never looked atsrc/engine/and the other folders. The glob is**now,test/coverage/joins.prettierignore, and the job itself is untouched.yarn test-format-allpasses on this branch.Checks
ref-044ab07a); API identical apart from the 11 allowed.namechangesalasql.min.jsunder node, Node 16 and 24,npm packand install: 8 of 8alasql.min.js524,616 bytes, 4,021 over develop at #2798 (0.8 percent); rows for the merge and for step 10 intest/parity/ledger.mdtest/parity/ledger.mdrow 10 carries this pull request's number; row 9 gets the end-of-phase benchmark.