Repository navigation
docs(PC0036): describe SetRecord as positioning and document the temporary-source exceptions - #225
Merged
Merged
Conversation
…orary-source exceptions Page.SetRecord only positions a page on the record's key, so a temporary record is only lost on a page that reads from the database. The page now explains that semantics, shows Page.RunModal and a SourceTableTemporary lookup page as the working patterns, and lists the exceptions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to ALCops/Analyzers#643 (issue ALCops/Analyzers#368). PC0036 now reports a temporary record passed to
Page.SetRecord()only when the page reads its records from the database. The page is rewritten to:SetRecord()positions the page on the record's key and never hands the data to the page, so the temporary data is lost only on a database-backed page;Page.RunModal()with the temporary record and aSourceTableTemporarylookup page withLoadRecords()plusSetRecord()(the pattern Microsoft uses in the Dataverse option lookups) as the working alternatives;SourceTableTemporary = true, aTableType = Temporarysource table, anOnFindRecordtrigger, and the methods that are never reported.Hugo build passes locally and the page renders at
docs/analyzers/platformcop/pc0036/.🤖 Generated with Claude Code