Repository navigation
fix(LC0092): check extension object names against the Object pattern - #626
Merged
Merged
Conversation
NamingPattern registered its object-name check on the base object kinds only, so the names of tableextension, pageextension, reportextension, enumextension, permissionsetextension, profileextension and pagecustomization objects were never matched, although the members inside them were. The object-name callback now also runs on those seven symbol kinds. It reuses the Object naming target and the existing AppSourceCop affix stripping, so no settings or schema change is needed. EnumProvider.SymbolKind gains PageCustomization, which exists at the 12.0 SDK floor like the six extension kinds. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LC0092 (
NamingPattern) checked object names only on base object kinds. The names of tableextension, pageextension, reportextension, enumextension, permissionsetextension, profileextension and pagecustomization objects were never checked, although the members inside them were.NamingPattern.cs: theAnalyzeObjectregistration now also covers those sevenSymbolKinds. They reuse theObjectnaming target and the existing AppSourceCop affix stripping, so there is no settings or schema change.EnumProvider.SymbolKindgainsPageCustomization, the one kind Common did not expose. All seven kinds exist at the 12.0 SDK floor (checked in nav-sdk-source v12.0).ObjectExtensionLowerCaseStart(table, page, report, enum and permission set extensions),ProfileExtensionLowerCaseStartandPageCustomizationLowerCaseStart.*PascalCasecounterparts of all three.Feature.ProfileExtensionsrequires runtime Fall2024.lc0092-naming-pattern.md: Purpose kind list, a Design-decision row, an SDK fact and a Test notes bullet.This is a behaviour change for existing users. Lowercase-starting extension names that passed before are now reported under the
Objecttarget, which is the intended fix for the false negative.Closes #619
Companion docs PR: ALCops/alcops.dev#219
Verification
dotnet test src/ALCops.LinterCop.Test/ --filter NamingPattern: 102/102 passed.ContinuousIntegrationBuild=true): 0 warnings, 0 errors.dotnet format --verify-no-changes: clean.Validate-Rules.ps1: OK.Review: 1 round of
/code-review high, no correctness findings. These non-correctness findings were left open, with justification:AnalyzeObjectstripping path as base objects.🤖 Generated with Claude Code