Repository navigation
Create the GitHub release when publishing, as the other languages do - #204
Merged
Merged
Conversation
…ges do The publish workflow wrote the version tag but stopped there, so every release page from 4.5.9 to 4.5.12 was created by hand. common-ci's steps/update-tag.ps1 tags and then runs gh release create with generated notes for the other languages. This step now does the same, and skips either half when it already exists, so a rerun finishes what a failed run left undone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish workflow (
.github/workflows/publish.yml) publishes the crates and writes the version tag, but it stops at the tag. No GitHub release is created, so the release pages for 4.5.9, 4.5.10, 4.5.11 and 4.5.12 were all created by hand after each publish.The other languages get their release from the publish. common-ci's
steps/update-tag.ps1pushes the tag and then runsgh release create --verify-tag --generate-notes. When this workflow's tag step was written it copied the tagging half and left out the release.Change
The "Tag what was published" step becomes "Tag and release what was published".
gh release create <version> --verify-tag --generate-notes --title <version>, unless that release is already there, so a rerun after a failure part way through finishes the job without failing on what already exists.GH_TOKENis the run's own token. The job already hascontents: write, which creating a release needs, and the comment on that permission now says so.gh release viewexits non-zero when the release is missing, so the step turns off$PSNativeCommandUseErrorActionPreferencearound that one call and treats the exit code as the answer.How it was verified
VERSIONandGH_TOKENin its environment.$ErrorActionPreference = 'stop'and GitHub's closingexit $LASTEXITCODE, withgit tag,git pushandgh release createreplaced by stubs andgh release viewleft real against this repository.gh release create 9.9.9 --verify-tag --generate-notes --title 9.9.9and exited 0.What remains
Nothing in this repository. Release notes are generated from the merged pull request titles, so they read as well as those titles do.