Repository navigation
fix: preserve special characters in title query filters - #153
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title filters are concatenated directly into the URL, so an item named with a
+is queried as though it contained a space. Ampersands split the query, fragments truncate it, and existing percent sequences are decoded prematurely.Encode the query key/value in the shared PathBuilder. Both sync and async item/vault lookups now preserve the original filter value. Extend their existing tests with reserved characters and Unicode titles, matching the decoded HTTP query rather than an unescaped URL string.
Fixes #123.
Validation: all 60 tests pass. Four sync/async item/vault regression cases fail before the fix. git diff --check passes. The suite reports one pre-existing asyncio-marker warning on a synchronous timeout test. Tests use mocked Connect responses; no live Connect server was used.