Repository navigation
Conversation
Replace tick() with os.clock() for elapsed time measurement, as recommended by the Roblox documentation: https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#tick
There was a problem hiding this comment.
🟡 Changes recommended
Use a wall/game-elapsed timer and a non-debouncing initial sentinel to avoid incorrect click rejection.
1 open issue
What changed in this PR
Replaces deprecated tick() with os.clock() for icon-toggle debounce timing.
Changes:
- Uses
os.clock()to calculate elapsed time between toggle attempts. - Preserves the existing 100 ms debounce interval.
| File | Summary |
|---|---|
src/init.lua |
Replaces tick() in the icon-toggle debounce logic; the timer API and initial sentinel require correction for reliable behavior. |
Review effort: Lite
ryanlua
approved these changes
Oct 25, 2026
ryanlua
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks for contributing!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace tick() with os.clock() for elapsed time measurement, as recommended by the Roblox documentation: https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#tick