-
-
-
-
+
+ {{ inputs.hidden('id', id) }}
+ {{ inputs.submit('validate', _x('button', 'Validate the model', 'datainjection'), _x('button', 'Validate the model', 'datainjection')) }}
\ No newline at end of file
diff --git a/tests/AbstractDataInjectionTestCase.php b/tests/AbstractDataInjectionTestCase.php
new file mode 100644
index 00000000..03b17a4a
--- /dev/null
+++ b/tests/AbstractDataInjectionTestCase.php
@@ -0,0 +1,64 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests;
+
+use Glpi\Tests\DbTestCase;
+use Plugin;
+
+abstract class AbstractDataInjectionTestCase extends DbTestCase
+{
+ public function setUp(): void
+ {
+ parent::setUp();
+ $this->login();
+
+ // Functions defined in hook.php (migration steps, needUpdateOrInstall(), ...)
+ // are only required when the plugin is actually (re)loaded, which
+ // Plugin::activate() skips once it is already active. Load explicitly so
+ // tests can call those functions directly.
+ Plugin::load('datainjection', true);
+ }
+
+ /**
+ * Run DDL (CREATE/DROP/ALTER TABLE) outside of the transaction that wraps each test.
+ */
+ protected function withoutTransaction(callable $callback): mixed
+ {
+ global $DB;
+ $DB->commit();
+ try {
+ return $callback();
+ } finally {
+ $DB->clearSchemaCache();
+ $DB->beginTransaction();
+ }
+ }
+}
diff --git a/tests/unit/ClientInjectionEscapeCsvFormulaTest.php b/tests/unit/ClientInjectionEscapeCsvFormulaTest.php
index 03ebaed3..b2ea0ee0 100644
--- a/tests/unit/ClientInjectionEscapeCsvFormulaTest.php
+++ b/tests/unit/ClientInjectionEscapeCsvFormulaTest.php
@@ -31,6 +31,7 @@
namespace GlpiPlugin\Datainjection\Tests\Unit;
use Glpi\Tests\DbTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
use PluginDatainjectionClientInjection;
use ReflectionMethod;
@@ -56,9 +57,7 @@ public static function escapeCsvFormulaProvider(): array
];
}
- /**
- * @dataProvider escapeCsvFormulaProvider
- */
+ #[DataProvider('escapeCsvFormulaProvider')]
public function testEscapeCsvFormula(mixed $value, mixed $expected): void
{
$escape_csv_formula = new ReflectionMethod(
diff --git a/tests/unit/CommonInjectionLibDateTimeTest.php b/tests/unit/CommonInjectionLibDateTimeTest.php
index 2cc8e5fe..412b100f 100644
--- a/tests/unit/CommonInjectionLibDateTimeTest.php
+++ b/tests/unit/CommonInjectionLibDateTimeTest.php
@@ -32,6 +32,7 @@
use Glpi\Tests\DbTestCase;
use Computer;
+use PHPUnit\Framework\Attributes\DataProvider;
use PluginDatainjectionComputerInjection;
use PluginDatainjectionCommonInjectionLib;
use ReflectionMethod;
@@ -84,9 +85,7 @@ public static function reformatDateTimeProvider(): array
];
}
- /**
- * @dataProvider reformatDateTimeProvider
- */
+ #[DataProvider('reformatDateTimeProvider')]
public function testReformatDateTime(string $original, string $date_format, string $expected): void
{
$lib = new PluginDatainjectionCommonInjectionLib(
diff --git a/tests/unit/CommonInjectionLibFloatDetectionTest.php b/tests/unit/CommonInjectionLibFloatDetectionTest.php
index e694d218..c3842b53 100644
--- a/tests/unit/CommonInjectionLibFloatDetectionTest.php
+++ b/tests/unit/CommonInjectionLibFloatDetectionTest.php
@@ -31,6 +31,7 @@
namespace GlpiPlugin\Datainjection\Tests\Unit;
use Glpi\Tests\DbTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
use PluginDatainjectionCommonInjectionLib;
use PluginDatainjectionComputerInjection;
@@ -88,9 +89,7 @@ public static function floatDetectionProvider(): array
];
}
- /**
- * @dataProvider floatDetectionProvider
- */
+ #[DataProvider('floatDetectionProvider')]
public function testFloatDetectionRegex(string $value, bool $expected_match): void
{
$regex = $this->getFloatDetectionRegex();
diff --git a/tests/unit/EngineInjectLineTest.php b/tests/unit/EngineInjectLineTest.php
new file mode 100644
index 00000000..f2172d1a
--- /dev/null
+++ b/tests/unit/EngineInjectLineTest.php
@@ -0,0 +1,145 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests\Unit;
+
+use Computer;
+use GlpiPlugin\Datainjection\Tests\AbstractDataInjectionTestCase;
+use PluginDatainjectionCommonInjectionLib;
+use PluginDatainjectionEngine;
+use PluginDatainjectionMapping;
+use PluginDatainjectionModel;
+use Session;
+
+final class EngineInjectLineTest extends AbstractDataInjectionTestCase
+{
+ private function createModelWithMappings(array $model_overrides = []): PluginDatainjectionModel
+ {
+ $model = $this->createItem(PluginDatainjectionModel::class, array_merge([
+ 'name' => 'Test_Engine_Model_' . uniqid(),
+ 'itemtype' => Computer::class,
+ 'entities_id' => $this->getTestRootEntity(true),
+ 'is_private' => 0,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ 'behavior_update' => 1,
+ ], $model_overrides));
+
+ $this->createItem(PluginDatainjectionMapping::class, [
+ 'models_id' => $model->getID(),
+ 'itemtype' => Computer::class,
+ 'rank' => 0,
+ 'name' => 'Name',
+ 'value' => 'name',
+ 'is_mandatory' => 1,
+ ]);
+
+ $this->createItem(PluginDatainjectionMapping::class, [
+ 'models_id' => $model->getID(),
+ 'itemtype' => Computer::class,
+ 'rank' => 1,
+ 'name' => 'Serial',
+ 'value' => 'serial',
+ 'is_mandatory' => 0,
+ ]);
+
+ return $model;
+ }
+
+ public function testInjectLineCreatesItemFromMappedCsvRow(): void
+ {
+ $model = $this->createModelWithMappings();
+
+ $engine = new PluginDatainjectionEngine($model, [], $model->fields['entities_id']);
+ $results = $engine->injectLine(['Test_Engine_Computer', 'ABC123'], 1);
+
+ self::assertSame(PluginDatainjectionCommonInjectionLib::SUCCESS, $results['status']);
+ self::assertSame(PluginDatainjectionCommonInjectionLib::IMPORT_ADD, $results['type']);
+ self::assertEmpty($engine->getLinesInError());
+
+ $computer = new Computer();
+ self::assertTrue($computer->getFromDB($results['Computer']));
+ self::assertSame('Test_Engine_Computer', $computer->fields['name']);
+ self::assertSame('ABC123', $computer->fields['serial']);
+ }
+
+ public function testInjectLineUpdatesExistingItemFromMappedCsvRow(): void
+ {
+ $model = $this->createModelWithMappings();
+
+ $computer = $this->createItem(Computer::class, [
+ 'name' => 'Test_Engine_Computer_Update',
+ 'entities_id' => $this->getTestRootEntity(true),
+ 'serial' => 'OLD_SERIAL',
+ ]);
+
+ $engine = new PluginDatainjectionEngine($model, [], $model->fields['entities_id']);
+ $results = $engine->injectLine(['Test_Engine_Computer_Update', 'NEW_SERIAL'], 1);
+
+ self::assertSame(PluginDatainjectionCommonInjectionLib::SUCCESS, $results['status']);
+ self::assertSame(PluginDatainjectionCommonInjectionLib::IMPORT_UPDATE, $results['type']);
+
+ $computer->getFromDB($computer->getID());
+ self::assertSame('NEW_SERIAL', $computer->fields['serial']);
+ }
+
+ public function testInjectLineRejectsNewItemWhenModelDisallowsAdd(): void
+ {
+ $model = $this->createModelWithMappings(['behavior_add' => 0]);
+
+ $engine = new PluginDatainjectionEngine($model, [], $model->fields['entities_id']);
+ $results = $engine->injectLine(['Test_Engine_Computer_NoAdd', 'XYZ'], 1);
+
+ self::assertSame(PluginDatainjectionCommonInjectionLib::ERROR_CANNOT_IMPORT, $results['status']);
+ self::assertNotEmpty($engine->getLinesInError());
+
+ $computer = new Computer();
+ self::assertFalse($computer->getFromDBbyCrit(['name' => 'Test_Engine_Computer_NoAdd']));
+ }
+
+ public function testInjectLineRejectsUpdateWhenModelDisallowsUpdate(): void
+ {
+ $model = $this->createModelWithMappings(['behavior_update' => 0]);
+
+ $computer = $this->createItem(Computer::class, [
+ 'name' => 'Test_Engine_Computer_NoUpdate',
+ 'entities_id' => $this->getTestRootEntity(true),
+ 'serial' => 'ORIGINAL',
+ ]);
+
+ $engine = new PluginDatainjectionEngine($model, [], $model->fields['entities_id']);
+ $results = $engine->injectLine(['Test_Engine_Computer_NoUpdate', 'CHANGED'], 1);
+
+ self::assertSame(PluginDatainjectionCommonInjectionLib::ERROR_CANNOT_UPDATE, $results['status']);
+
+ $computer->getFromDB($computer->getID());
+ self::assertSame('ORIGINAL', $computer->fields['serial']);
+ }
+}
diff --git a/tests/unit/GroupInjectionTest.php b/tests/unit/GroupInjectionTest.php
index 693bb25f..010b6b3e 100644
--- a/tests/unit/GroupInjectionTest.php
+++ b/tests/unit/GroupInjectionTest.php
@@ -30,6 +30,7 @@
namespace GlpiPlugin\Datainjection\Tests\Unit;
+use PHPUnit\Framework\Attributes\DataProvider;
use PluginDatainjectionComputerInjection;
use PluginDatainjectionITILCategoryInjection;
use Glpi\Tests\DbTestCase;
@@ -78,10 +79,7 @@ public static function assignGroupToInjectedAssignableItemProvider(): array
];
}
- /**
- *
- * @dataProvider assignGroupToInjectedAssignableItemProvider
- */
+ #[DataProvider('assignGroupToInjectedAssignableItemProvider')]
public function testAssigneGroupToInjectedAssignableItem(
string $group_field,
array $injected_data,
@@ -163,10 +161,7 @@ public static function groupIsAssignedToInjectedNonAssignableItemProvider(): arr
];
}
- /**
- *
- * @dataProvider groupIsAssignedToInjectedNonAssignableItemProvider
- */
+ #[DataProvider('groupIsAssignedToInjectedNonAssignableItemProvider')]
public function testGroupIsAssignedToInjectedNonAssignableItem(
array $injected_data,
array $mandatory_fields,
@@ -250,8 +245,8 @@ public static function groupIsUpdatedOnExistingAssignableItemProvider(): array
* Updating an existing AssignableItem (Computer) via injection must route the group through
* the AssignableItem normalisation path and persist it in Group_Item.
*
- * @dataProvider groupIsUpdatedOnExistingAssignableItemProvider
*/
+ #[DataProvider('groupIsUpdatedOnExistingAssignableItemProvider')]
public function testGroupIsUpdatedOnExistingAssignableItem(
string $group_field,
array $injected_data,
diff --git a/tests/unit/MigrationTest.php b/tests/unit/MigrationTest.php
new file mode 100644
index 00000000..c5f34dbb
--- /dev/null
+++ b/tests/unit/MigrationTest.php
@@ -0,0 +1,106 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests\Unit;
+
+use DBmysql;
+use GlpiPlugin\Datainjection\Tests\AbstractDataInjectionTestCase;
+use Migration;
+use Psr\Log\LogLevel;
+use Session;
+
+final class MigrationTest extends AbstractDataInjectionTestCase
+{
+ public function testMigration2158To2159FixesLegacyNegativeEntityId(): void
+ {
+ /** @var DBmysql $DB */
+ global $DB;
+
+ $table = 'glpi_plugin_datainjection_models';
+
+ // Recreate the pre-2158 column shape: signed, defaulting to -1,
+ // exactly as described in the migration's own comments.
+ $this->withoutTransaction(static function () use ($DB, $table): void {
+ $DB->doQuery(sprintf("ALTER TABLE `%s` CHANGE `entities_id` `entities_id` int NOT NULL default '-1'", $table));
+ });
+ // GLPI itself warns on signed keys; expected here since we are
+ // deliberately recreating the legacy (pre-migration) column shape.
+ $this->hasPhpLogRecordThatContains(
+ 'Usage of signed integers in primary or foreign keys is discouraged',
+ LogLevel::WARNING,
+ );
+
+ $id = null;
+
+ try {
+ $DB->insert($table, [
+ 'name' => 'Test_Migration_Legacy_Private_Model',
+ 'itemtype' => 'Computer',
+ 'entities_id' => -1,
+ 'is_private' => 1,
+ 'is_recursive' => 0,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ ]);
+ $id = $DB->insertId();
+
+ $this->withoutTransaction(static function (): void {
+ plugin_datainjection_migration_2158_2159(new Migration(PLUGIN_DATAINJECTION_VERSION));
+ });
+
+ $row = $DB->request(['FROM' => $table, 'WHERE' => ['id' => $id]])->current();
+
+ self::assertSame(0, (int) $row['entities_id']);
+ self::assertSame(1, (int) $row['is_private']);
+ self::assertSame(1, (int) $row['is_recursive']);
+
+ $column = null;
+ foreach ($DB->listFields($table) as $field) {
+ if ($field['Field'] === 'entities_id') {
+ $column = $field;
+ }
+ }
+
+ self::assertNotNull($column);
+ self::assertStringContainsString('unsigned', $column['Type']);
+ } finally {
+ if ($id !== null) {
+ $DB->delete($table, ['id' => $id]);
+ }
+
+ // Guarantee the column ends up unsigned regardless of whether the
+ // assertions above passed, matching the schema every other test
+ // in this suite relies on.
+ $this->withoutTransaction(static function () use ($DB, $table): void {
+ $DB->doQuery(sprintf("ALTER TABLE `%s` CHANGE `entities_id` `entities_id` int unsigned NOT NULL default '0'", $table));
+ });
+ }
+ }
+}
diff --git a/tests/unit/ModelCrudTest.php b/tests/unit/ModelCrudTest.php
new file mode 100644
index 00000000..4c325fa1
--- /dev/null
+++ b/tests/unit/ModelCrudTest.php
@@ -0,0 +1,120 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests\Unit;
+
+use Computer;
+use GlpiPlugin\Datainjection\Tests\AbstractDataInjectionTestCase;
+use PluginDatainjectionMapping;
+use PluginDatainjectionModel;
+use Session;
+
+final class ModelCrudTest extends AbstractDataInjectionTestCase
+{
+ public function testAddRefusesModelWithoutAName(): void
+ {
+ $model = new PluginDatainjectionModel();
+ $id = $model->add([
+ 'name' => '',
+ 'itemtype' => Computer::class,
+ 'entities_id' => 0,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ 'behavior_update' => 0,
+ ]);
+
+ self::assertFalse($id);
+ $this->hasSessionMessages(ERROR, ['Please enter a name for the model']);
+ }
+
+ public function testAddRefusesModelWithNeitherAddNorUpdateBehavior(): void
+ {
+ $model = new PluginDatainjectionModel();
+ $id = $model->add([
+ 'name' => 'Test_Model_Crud_NoBehavior',
+ 'itemtype' => Computer::class,
+ 'entities_id' => 0,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 0,
+ 'behavior_update' => 0,
+ ]);
+
+ self::assertFalse($id);
+ $this->hasSessionMessages(ERROR, ['Your model should allow import and/or update of data']);
+ }
+
+ public function testUpdateRefusesChangingOwnerOfAPrivateModel(): void
+ {
+ $model = $this->createItem(PluginDatainjectionModel::class, [
+ 'name' => 'Test_Model_Crud_Private',
+ 'itemtype' => Computer::class,
+ 'entities_id' => 0,
+ 'is_private' => PluginDatainjectionModel::MODEL_PRIVATE,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ 'behavior_update' => 0,
+ ]);
+
+ $success = $model->update([
+ 'id' => $model->getID(),
+ 'is_private' => 1,
+ 'users_id' => Session::getLoginUserID() + 1,
+ ]);
+
+ self::assertFalse($success);
+ $this->hasSessionMessages(ERROR, ['You are not the initial creator of this model']);
+ }
+
+ public function testPurgingAModelDeletesItsMappings(): void
+ {
+ $model = $this->createItem(PluginDatainjectionModel::class, [
+ 'name' => 'Test_Model_Crud_Purge',
+ 'itemtype' => Computer::class,
+ 'entities_id' => 0,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ 'behavior_update' => 0,
+ ]);
+
+ $mapping = $this->createItem(PluginDatainjectionMapping::class, [
+ 'models_id' => $model->getID(),
+ 'itemtype' => Computer::class,
+ 'rank' => 0,
+ 'name' => 'Name',
+ 'value' => 'name',
+ 'is_mandatory' => 1,
+ ]);
+
+ $this->deleteItem(PluginDatainjectionModel::class, $model->getID(), true);
+
+ $reloaded_mapping = new PluginDatainjectionMapping();
+ self::assertFalse($reloaded_mapping->getFromDB($mapping->getID()));
+ }
+}
diff --git a/tests/unit/ModelRightsTest.php b/tests/unit/ModelRightsTest.php
new file mode 100644
index 00000000..9f4d0a5d
--- /dev/null
+++ b/tests/unit/ModelRightsTest.php
@@ -0,0 +1,122 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests\Unit;
+
+use Computer;
+use Entity;
+use GlpiPlugin\Datainjection\Tests\AbstractDataInjectionTestCase;
+use PluginDatainjectionModel;
+use Session;
+use User;
+
+final class ModelRightsTest extends AbstractDataInjectionTestCase
+{
+ /**
+ * The default test user's active session is scoped to a fixed set of
+ * entities that does not include the root entity, so models under test
+ * need a real entity from that set, not entities_id => 0.
+ */
+ private function createAccessibleEntityId(): int
+ {
+ return (int) $this->createItem(Entity::class, [
+ 'name' => 'Test_Model_Rights_Entity_' . uniqid(),
+ 'entities_id' => 0,
+ ])->getID();
+ }
+
+ private function createModel(array $overrides = []): PluginDatainjectionModel
+ {
+ return $this->createItem(PluginDatainjectionModel::class, array_merge([
+ 'name' => 'Test_Model_Rights_' . uniqid(),
+ 'itemtype' => Computer::class,
+ 'entities_id' => $this->createAccessibleEntityId(),
+ 'is_private' => PluginDatainjectionModel::MODEL_PUBLIC,
+ 'users_id' => Session::getLoginUserID(),
+ 'behavior_add' => 1,
+ 'behavior_update' => 1,
+ ], $overrides));
+ }
+
+ public function testCanCreateItemIsDeniedWhenNativeItemtypeRightIsRemoved(): void
+ {
+ $model = $this->createModel();
+
+ self::assertTrue($model->canCreateItem());
+
+ $_SESSION['glpiactiveprofile']['computer'] = 0;
+ self::assertFalse($model->canCreateItem());
+ }
+
+ public function testCanCreateItemIsAllowedWhenNativeItemtypeRightIsPresent(): void
+ {
+ $model = $this->createModel();
+
+ $_SESSION['glpiactiveprofile']['computer'] = ALLSTANDARDRIGHT;
+ self::assertTrue($model->canCreateItem());
+ }
+
+ public function testCanViewItemHidesPrivateModelOwnedByAnotherUser(): void
+ {
+ $model = $this->createModel([
+ 'is_private' => PluginDatainjectionModel::MODEL_PRIVATE,
+ 'users_id' => getItemByTypeName(User::class, 'tech', true),
+ ]);
+
+ self::assertFalse($model->canViewItem());
+ }
+
+ public function testCanViewItemAllowsPrivateModelOwnedBySelf(): void
+ {
+ $model = $this->createModel([
+ 'is_private' => PluginDatainjectionModel::MODEL_PRIVATE,
+ ]);
+
+ self::assertTrue($model->canViewItem());
+ }
+
+ public function testCanViewItemRespectsEntityRestriction(): void
+ {
+ $entity = $this->createItem(Entity::class, [
+ 'name' => 'Test_Model_Rights_Entity',
+ 'entities_id' => 0,
+ ]);
+
+ $model = $this->createModel([
+ 'entities_id' => $entity->getID(),
+ 'is_recursive' => 0,
+ ]);
+
+ self::assertTrue($model->canViewItem());
+
+ $_SESSION['glpiactiveentities'] = [0];
+ self::assertFalse($model->canViewItem());
+ }
+}
diff --git a/tests/unit/PluginLifecycleTest.php b/tests/unit/PluginLifecycleTest.php
new file mode 100644
index 00000000..61ef2b85
--- /dev/null
+++ b/tests/unit/PluginLifecycleTest.php
@@ -0,0 +1,57 @@
+.
+ * -------------------------------------------------------------------------
+ * @copyright Copyright (C) 2007-2023 by DataInjection plugin team.
+ * @license GPLv2 https://www.gnu.org/licenses/gpl-2.0.html
+ * @link https://github.com/pluginsGLPI/datainjection
+ * -------------------------------------------------------------------------
+ */
+
+namespace GlpiPlugin\Datainjection\Tests\Unit;
+
+use GlpiPlugin\Datainjection\Tests\AbstractDataInjectionTestCase;
+use Plugin;
+
+final class PluginLifecycleTest extends AbstractDataInjectionTestCase
+{
+ private function getPlugin(): Plugin
+ {
+ $plugin = new Plugin();
+ $plugin->getFromDBbyDir('datainjection');
+
+ return $plugin;
+ }
+
+ public function testPluginIsInstalledAndActivatedByDefault(): void
+ {
+ $plugin = $this->getPlugin();
+
+ self::assertSame(Plugin::ACTIVATED, (int) $plugin->fields['state']);
+ }
+
+ public function testNeedUpdateOrInstallReportsUpToDateWhenFullyInstalled(): void
+ {
+ self::assertSame(-1, plugin_datainjection_needUpdateOrInstall());
+ }
+}