From 5d15050a51012109aa91e0514cc23ebe3f5c0ef8 Mon Sep 17 00:00:00 2001 From: Andrei Markin Date: Wed, 21 Oct 2026 00:02:08 +0400 Subject: [PATCH] fix(io): add return to all writers * clickhouse and sqldb --- libs/io/garf/io/version.py | 2 +- libs/io/garf/io/writers/clickhouse_writer.py | 3 ++- libs/io/garf/io/writers/sheets_writer.py | 5 ++--- libs/io/garf/io/writers/sqldb_writer.py | 1 + 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libs/io/garf/io/version.py b/libs/io/garf/io/version.py index 262e275b..89163c21 100644 --- a/libs/io/garf/io/version.py +++ b/libs/io/garf/io/version.py @@ -11,4 +11,4 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -__version__ = '1.5.2' +__version__ = '1.5.3' diff --git a/libs/io/garf/io/writers/clickhouse_writer.py b/libs/io/garf/io/writers/clickhouse_writer.py index 9417aee1..fa4a04a0 100644 --- a/libs/io/garf/io/writers/clickhouse_writer.py +++ b/libs/io/garf/io/writers/clickhouse_writer.py @@ -115,7 +115,7 @@ def __init__( ) @tracer.start_as_current_span('clickhouse.write') - def write(self, report: garf_report.GarfReport, destination: str) -> None: + def write(self, report: garf_report.GarfReport, destination: str) -> str: """Writes Garf report to the table. Args: @@ -157,6 +157,7 @@ def write(self, report: garf_report.GarfReport, destination: str) -> None: database=database, ) logger.debug('Writing to %s.%s is completed', database, table) + return f'[Clickhouse] - at {database}.{table}' def _split_destination(self, destination: str) -> tuple[str, str]: parts = destination.split('.') diff --git a/libs/io/garf/io/writers/sheets_writer.py b/libs/io/garf/io/writers/sheets_writer.py index c755ed81..06c9067d 100644 --- a/libs/io/garf/io/writers/sheets_writer.py +++ b/libs/io/garf/io/writers/sheets_writer.py @@ -106,9 +106,8 @@ def write( self._add_rows_if_needed(num_data_rows, sheet) sheet.append_rows(report.results, value_input_option='RAW') - success_msg = f'Report is saved to {sheet.url}' - logger.info(success_msg) - return success_msg + logger.info('Report is saved to %s', sheet.url) + return f'[Sheets] at {sheet.url}' @property @tracer.start_as_current_span('sheets.create_client') diff --git a/libs/io/garf/io/writers/sqldb_writer.py b/libs/io/garf/io/writers/sqldb_writer.py index 7a5d38f3..5db1911e 100644 --- a/libs/io/garf/io/writers/sqldb_writer.py +++ b/libs/io/garf/io/writers/sqldb_writer.py @@ -101,6 +101,7 @@ def write(self, report: garf_report.GarfReport, destination: str) -> None: write_params.update({'dtype': dtypes}) df.to_sql(**write_params) logger.debug('Writing to %s is completed', destination) + return f'[SQL] - at {destination}' @property def engine(self) -> sqlalchemy.engine.Engine: