From 0b21725761ec8f24d9acb125cf108f1229a5cd4d Mon Sep 17 00:00:00 2001 From: Kevin DF <53238640+fishbone-git@users.noreply.github.com> Date: Sun, 8 Nov 2026 19:28:06 -0500 Subject: [PATCH 1/2] don't crash on read faillure to allow for notify --- src/pyftms/client/backends/controller.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pyftms/client/backends/controller.py b/src/pyftms/client/backends/controller.py index 1d778f6d76..74096d9011 100644 --- a/src/pyftms/client/backends/controller.py +++ b/src/pyftms/client/backends/controller.py @@ -115,7 +115,8 @@ async def subscribe(self, cli: BleakClient) -> None: return if c := cli.services.get_characteristic(TRAINING_STATUS_UUID): - self._on_training_status(c, await cli.read_gatt_char(c)) + if "read" in c.properties: + self._on_training_status(c, await cli.read_gatt_char(c)) await cli.start_notify(c, self._on_training_status) if c := cli.services.get_characteristic(STATUS_UUID): From efbaf04d5223b2172c16fd04394e2cd195e0c28f Mon Sep 17 00:00:00 2001 From: Kevin DF <53238640+fishbone-git@users.noreply.github.com> Date: Sun, 8 Nov 2026 19:37:01 -0500 Subject: [PATCH 2/2] await notify for trainer --- src/pyftms/client/backends/controller.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/pyftms/client/backends/controller.py b/src/pyftms/client/backends/controller.py index 74096d9011..f7d5080f0c 100644 --- a/src/pyftms/client/backends/controller.py +++ b/src/pyftms/client/backends/controller.py @@ -115,8 +115,6 @@ async def subscribe(self, cli: BleakClient) -> None: return if c := cli.services.get_characteristic(TRAINING_STATUS_UUID): - if "read" in c.properties: - self._on_training_status(c, await cli.read_gatt_char(c)) await cli.start_notify(c, self._on_training_status) if c := cli.services.get_characteristic(STATUS_UUID):