From 2fc939e5c16fc8394c0f13bf6fe1d04b6dec206b Mon Sep 17 00:00:00 2001 From: Goran Jovic Date: Fri, 2 Oct 2026 18:23:56 +0200 Subject: [PATCH 1/4] fix: linter error for bare url --- foundations/object_basics/03_fibonacci/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/object_basics/03_fibonacci/README.md b/foundations/object_basics/03_fibonacci/README.md index 35053046c39..efb7ee4a9cf 100644 --- a/foundations/object_basics/03_fibonacci/README.md +++ b/foundations/object_basics/03_fibonacci/README.md @@ -1,6 +1,6 @@ # Exercise 03 - Fibonacci -Create a function that returns a specific member of the Fibonacci sequence (series of numbers in which each number is the sum of the two preceding numbers). To learn more about Fibonacci sequences, go to: https://en.wikipedia.org/wiki/Fibonacci_sequence +Create a function that returns a specific member of the Fibonacci sequence (series of numbers in which each number is the sum of the two preceding numbers). To learn more about Fibonacci sequences, go to: In this exercise, the Fibonacci sequence used is 1, 1, 2, 3, 5, 8, etc. (i.e. starting at 1, not 0): From 8ff1e9c0d082400e11be7918c4cece648718cb08 Mon Sep 17 00:00:00 2001 From: Goran Jovic Date: Fri, 2 Oct 2026 18:33:40 +0200 Subject: [PATCH 2/4] fix: update README.md and tests to return "OOPS" for 0 --- foundations/object_basics/03_fibonacci/README.md | 2 +- foundations/object_basics/03_fibonacci/fibonacci.spec.js | 4 ++-- .../03_fibonacci/solution/fibonacci-solution.js | 6 +----- .../03_fibonacci/solution/fibonacci-solution.spec.js | 4 ++-- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/foundations/object_basics/03_fibonacci/README.md b/foundations/object_basics/03_fibonacci/README.md index efb7ee4a9cf..d11e525589e 100644 --- a/foundations/object_basics/03_fibonacci/README.md +++ b/foundations/object_basics/03_fibonacci/README.md @@ -9,4 +9,4 @@ fibonacci(4); // returns the 4th member of the series: 3 (1, 1, 2, 3) fibonacci(6); // returns 8 ``` -If given a negative number, `NaN`, or not a number type at all, the function should return `"OOPS"`, i.e. only proceed with positive numbers. +If given 0, a negative number, NaN, or not a number type at all, the function should return "OOPS", i.e. only proceed with positive numbers. diff --git a/foundations/object_basics/03_fibonacci/fibonacci.spec.js b/foundations/object_basics/03_fibonacci/fibonacci.spec.js index 8f2df2301e9..297f2db69db 100644 --- a/foundations/object_basics/03_fibonacci/fibonacci.spec.js +++ b/foundations/object_basics/03_fibonacci/fibonacci.spec.js @@ -16,8 +16,8 @@ describe('fibonacci', () => { test.skip('25th fibonacci number is 75025', () => { expect(fibonacci(25)).toBe(75025); }); - test.skip('0th fibonacci number is 0', () => { - expect(fibonacci(0)).toBe(0); + test.skip('doesn\'t accept 0', () => { + expect(fibonacci(0)).toBe("OOPS"); }); test.skip('doesn\'t accept negatives', () => { expect(fibonacci(-25)).toBe("OOPS"); diff --git a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js index 642c8cbc532..9e227a063d5 100644 --- a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js +++ b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js @@ -1,13 +1,9 @@ const fibonacci = function(count) { // checks argument's type and makes sure we use // a number throughout rest of function. - if (typeof count !== 'number' || count < 0 || Number.isNaN(count)) { + if (typeof count !== 'number' || count <= 0 || Number.isNaN(count)) { return "OOPS"; } - - if (count === 0) { - return 0; - } let firstPrev = 1; let secondPrev = 0; diff --git a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.spec.js b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.spec.js index 15338c71e63..126529f31d7 100644 --- a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.spec.js +++ b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.spec.js @@ -16,8 +16,8 @@ describe('fibonacci', () => { test('25th fibonacci number is 75025', () => { expect(fibonacci(25)).toBe(75025); }); - test('0th fibonacci number is 0', () => { - expect(fibonacci(0)).toBe(0); + test('doesn\'t accept 0', () => { + expect(fibonacci(0)).toBe("OOPS"); }); test('doesn\'t accept negatives', () => { expect(fibonacci(-25)).toBe("OOPS"); From 5ae61ff43ecaa89c965a2a1388fe1d0b01a2121b Mon Sep 17 00:00:00 2001 From: Goran Jovic Date: Fri, 2 Oct 2026 18:39:34 +0200 Subject: [PATCH 3/4] fix: missing backticks --- foundations/object_basics/03_fibonacci/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/object_basics/03_fibonacci/README.md b/foundations/object_basics/03_fibonacci/README.md index d11e525589e..70b24207c23 100644 --- a/foundations/object_basics/03_fibonacci/README.md +++ b/foundations/object_basics/03_fibonacci/README.md @@ -9,4 +9,4 @@ fibonacci(4); // returns the 4th member of the series: 3 (1, 1, 2, 3) fibonacci(6); // returns 8 ``` -If given 0, a negative number, NaN, or not a number type at all, the function should return "OOPS", i.e. only proceed with positive numbers. +If given 0, a negative number, `NaN`, or not a number type at all, the function should return `"OOPS"`, i.e. only proceed with positive numbers. From b9dc0f9f342b82b6694b5e186e574bee70ef03e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Goran=20Jovi=C4=87?= Date: Fri, 2 Oct 2026 18:55:27 +0200 Subject: [PATCH 4/4] Update foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com> --- .../object_basics/03_fibonacci/solution/fibonacci-solution.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js index 9e227a063d5..d4a7609ec8d 100644 --- a/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js +++ b/foundations/object_basics/03_fibonacci/solution/fibonacci-solution.js @@ -1,6 +1,6 @@ const fibonacci = function(count) { // checks argument's type and makes sure we use - // a number throughout rest of function. + // a positive number throughout rest of function. if (typeof count !== 'number' || count <= 0 || Number.isNaN(count)) { return "OOPS"; }