From eb5fecfe3f0c20bf82e2ec17a1bb7e3b1a95c0b9 Mon Sep 17 00:00:00 2001 From: ben Date: Mon, 28 Sep 2026 11:21:43 +0200 Subject: [PATCH 1/3] chore: format web after changeset version, like react --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5708f46..d59ab6c 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ ], "scripts": { "changeset": "changeset", - "version": "changeset version && npm run --prefix react format", + "version": "changeset version && npm run --prefix react format && npm run --prefix web format", "publish": "changeset publish" }, "devDependencies": { From 691052241e308a2d3511497defa365fc97942afe Mon Sep 17 00:00:00 2001 From: ben Date: Mon, 28 Sep 2026 11:22:18 +0200 Subject: [PATCH 2/3] ci: fail a pull request whose changesets would generate an unformatted changelog --- .github/workflows/changelog-check.yaml | 41 ++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/changelog-check.yaml diff --git a/.github/workflows/changelog-check.yaml b/.github/workflows/changelog-check.yaml new file mode 100644 index 0000000..5d878fa --- /dev/null +++ b/.github/workflows/changelog-check.yaml @@ -0,0 +1,41 @@ +name: Changelog Check + +on: + pull_request: + branches: + - main + paths: + - .changeset/** + - package.json + - embed/** + - react/** + - web/** + +jobs: + check: + name: Generated changelogs are formatted + runs-on: ubuntu-latest + # The version PR itself is checked by each package's Formatting job. + if: github.head_ref != 'changeset-release/main' + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version: "24" + + - name: Install dependencies + run: npm ci + + # The version PR regenerates every CHANGELOG from the pending changesets with this exact + # script; running it here fails the pull request instead of the release. + - name: Generate the changelogs the release will write + run: npm run version + + - name: Check they are formatted + run: | + npm run --prefix react test:format + npm run --prefix web test:format From 5f392cf684ecb6a128ba1e47bea806a10af49f32 Mon Sep 17 00:00:00 2001 From: ben Date: Mon, 28 Sep 2026 11:24:49 +0200 Subject: [PATCH 3/3] ci: the version PR is pure changeset output; a changeset that would generate an unformatted changelog fails its own pull request --- .changeset/web-embed-on-core.md | 1 - .github/workflows/changelog-check.yaml | 5 +++-- package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.changeset/web-embed-on-core.md b/.changeset/web-embed-on-core.md index 95b8a58..d4f8da0 100644 --- a/.changeset/web-embed-on-core.md +++ b/.changeset/web-embed-on-core.md @@ -3,7 +3,6 @@ --- **Your pages are now ready for AI agents.** While the editor is open, an agent in your visitor's browser (ChatGPT's browser, Chrome with WebMCP) can read and fill the form, move between pages and submit it, with the same permissions as any other integration. It is on by default: add `webmcp="false"` to the script tag to turn it off. - - **More PDF links open in SimplePDF**: `Report.PDF`, `form.pdf?v=2` and `guide.pdf#page=3` used to open in the browser. - **Japanese and Dutch**: pages in either language open the editor in that language. - **Stored documents open directly**: a link to a SimplePDF document (`/documents/`) opens it in the editor. diff --git a/.github/workflows/changelog-check.yaml b/.github/workflows/changelog-check.yaml index 5d878fa..d8044d3 100644 --- a/.github/workflows/changelog-check.yaml +++ b/.github/workflows/changelog-check.yaml @@ -30,8 +30,9 @@ jobs: - name: Install dependencies run: npm ci - # The version PR regenerates every CHANGELOG from the pending changesets with this exact - # script; running it here fails the pull request instead of the release. + # The version PR is pure `changeset version` output. Running it here, then the formatting + # checks the version PR runs, fails the pull request that adds a changeset whose generated + # CHANGELOG is not formatted, so the release never needs a fix. - name: Generate the changelogs the release will write run: npm run version diff --git a/package.json b/package.json index d59ab6c..b281511 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ ], "scripts": { "changeset": "changeset", - "version": "changeset version && npm run --prefix react format && npm run --prefix web format", + "version": "changeset version", "publish": "changeset publish" }, "devDependencies": {