From 761e5c3cb412cc6a33b447faf589085af7476e55 Mon Sep 17 00:00:00 2001 From: elijulian Date: Wed, 21 Oct 2026 18:06:56 +0300 Subject: [PATCH] Build with JDK 21 while keeping Java 11 bytecode and API docs. Require JDK 21 for the Maven toolchain so {@snippet} Javadoc works, compile with --release 11 for runtime compatibility, and drop doclint-invalid lang attributes. --- .github/workflows/pull_request_worklow.yml | 2 +- pom.xml | 29 +++++++++++++++---- .../zmanim/ComprehensiveZmanimCalendar.java | 14 ++++----- 3 files changed, 32 insertions(+), 13 deletions(-) diff --git a/.github/workflows/pull_request_worklow.yml b/.github/workflows/pull_request_worklow.yml index 68659bff..73608760 100644 --- a/.github/workflows/pull_request_worklow.yml +++ b/.github/workflows/pull_request_worklow.yml @@ -11,7 +11,7 @@ jobs: uses: actions/setup-java@v5 with: distribution: 'temurin' - java-version: 11 + java-version: 21 cache: 'maven' - name: Run tests diff --git a/pom.xml b/pom.xml index 4d7e2b2a..c379fbff 100644 --- a/pom.xml +++ b/pom.xml @@ -60,6 +60,7 @@ maven-javadoc-plugin 3.2.0 + 11 todo @@ -68,7 +69,7 @@ - https://docs.oracle.com/en/java/javase/17/docs/api/ + https://docs.oracle.com/en/java/javase/11/docs/api/ private
KosherJava.com]]>
@@ -118,10 +119,29 @@ 3.10.1 UTF-8 - 11 - 11 + 11 + + org.apache.maven.plugins + maven-enforcer-plugin + 3.5.0 + + + enforce-java + + enforce + + + + + [21,) + + + + + + org.apache.maven.plugins maven-surefire-plugin @@ -140,7 +160,6 @@ - 11 - 11 + 11 diff --git a/src/main/java/com/kosherjava/zmanim/ComprehensiveZmanimCalendar.java b/src/main/java/com/kosherjava/zmanim/ComprehensiveZmanimCalendar.java index 38001068..086f5362 100644 --- a/src/main/java/com/kosherjava/zmanim/ComprehensiveZmanimCalendar.java +++ b/src/main/java/com/kosherjava/zmanim/ComprehensiveZmanimCalendar.java @@ -1275,7 +1275,7 @@ public Instant getSofZmanShmaMGA120Minutes() { * #getSeaLevelSunset() sea level sunset}. This is the opinion of the חידושי וכללות הרז״ה in סימן ב׳ סע״ג וסע״ד and סי׳ ז׳ סע״ב and the מנורה הטהורה as mentioned by ישראל והזמנים מנורה הטהורה as mentioned by ישראל והזמנים ח״א סי׳ ז׳ פ״ג או׳ ט״ז. Also see אשר לשלמה, מועד, סי׳ ה׳. Three shaos zmaniyos are calculated * based on this day and added to {@link #getAlos16Point1Degrees() alos} to reach this time. This time is 3 shaos @@ -3917,7 +3917,7 @@ public Instant getPolarPlagHaminchaBenIshChai() { /** * In Polar regions during the period where the sun is above the horizon 24-hours a day, Rav Moshe Sternbuch in מועדים וזמנים ח״ב ס׳ קנ״ה הע׳ א׳ (ח״ד ס׳ ת״א + * "https://hebrewbooks.org/pdfpager.aspx?req=19963&st=&pgnum=316">מועדים וזמנים ח״ב ס׳ קנ״ה הע׳ א׳ (ח״ד ס׳ ת״א * הע׳ א׳ in the new edition) and in תשובות והנהגות ח״א ס׳ שט״ו, and ח״ה ס׳ פ״ד ruled that during the Polar summer night-based @@ -3930,10 +3930,10 @@ public Instant getPolarPlagHaminchaBenIshChai() { * hashachar only occurs in Antarctica and in uninhabited extreme northern regions. This means almost every northern * inhabited location has an alos hashachar and "day" even on December 21st. This method considers alos to be * {@link #getAlos16Point1Degrees()}. - *

It should be noted that in the מועדים וזמנים linked above that was published in 1961, Rav Moshe - * Sternbuch mentions that [ולתפלה, היום מתהלק, עד י״ב שעות שחרית, ומאז מנחה, ומעריב מתפלל סמוך ללילה כרבי יהודה כנל״ד ...]. - * This comment (in () in the original, and [] in the new edition published in 2023) was not brought down in the תשובות והנהגות vol. 1 that was published in 1977 nor in vol. 5. published in 2009. Since it is not clear to me if this + *

It should be noted that in the מועדים וזמנים linked above that was published in 1961, Rav Moshe + * Sternbuch mentions that [ולתפלה, היום מתהלק, עד י״ב שעות שחרית, ומאז מנחה, ומעריב מתפלל סמוך ללילה כרבי יהודה כנל״ד ...]. + * This comment (in () in the original, and [] in the new edition published in 2023) was not brought down in the + * תשובות והנהגות vol. 1 that was published in 1977 nor in vol. 5. published in 2009. Since it is not clear to me if this * constitutes a retraction, the calculations for the start of mincha mentioned in the Moadim Uzmanim was omitted. This * is 12 hours after the start of the day (either {@link #getChatzosHalayla()} in the Polar summer, or {@link #getChatzosHayom()} * in the Polar winter. {@link #getPolarPlagHaminchaTeshuvosVehanhagos()} was included and is the start of the time that @@ -3973,7 +3973,7 @@ public Instant getPolarStartOfDayTeshuvosVehanhagos() { /** * In Polar regions during the period where the sun is above the horizon 24-hours a day, Rav Moshe Sternbuch in מועדים וזמנים ח״ב ס׳ קנ״ה הע׳ א׳ (ח״ד ס׳ ת״א + * "https://hebrewbooks.org/pdfpager.aspx?req=19963&st=&pgnum=316">מועדים וזמנים ח״ב ס׳ קנ״ה הע׳ א׳ (ח״ד ס׳ ת״א * הע׳ א׳ in the new edition) mentions the concept of zmanim based on his {@link #getPolarStartOfDayTeshuvosVehanhagos()}. * This calculates {@link #getPlagHamincha(Instant, Instant, boolean)} as 10.75 sha'os zmaniyos starting 24 hours prior * to the current start/end of the current day. This will be very close to 2.5 clock hours before the start/end of the day.