From 6e5e5c7ec036cd7625bbc8acc47c02cb5ef7add8 Mon Sep 17 00:00:00 2001 From: ckoegel Date: Wed, 4 Nov 2026 15:38:52 -0500 Subject: [PATCH 1/2] DX-4156 Remove Env Vars from Unit Tests --- .github/workflows/test-pr.yml | 17 -------- Rakefile | 2 +- spec/smoke/calls_api_spec.rb | 2 +- spec/smoke/conferences_api_spec.rb | 2 +- spec/smoke/endpoints_api_spec.rb | 2 + spec/smoke/media_api_spec.rb | 2 + spec/smoke/messages_api_spec.rb | 2 + spec/smoke/mfa_api_spec.rb | 2 + spec/smoke/multi_channel_api_spec.rb | 2 + spec/smoke/phone_number_lookup_api_spec.rb | 2 + spec/smoke/recordings_api_spec.rb | 2 +- spec/smoke/smoke_helper.rb | 42 +++++++++++++++++++ spec/smoke/statistics_api_spec.rb | 2 + spec/smoke/toll_free_verification_api_spec.rb | 2 + spec/smoke/transcriptions_api_spec.rb | 2 +- spec/spec_helper.rb | 42 ------------------- spec/unit/api/calls_api_spec.rb | 4 +- spec/unit/api/conferences_api_spec.rb | 2 + spec/unit/api/endpoints_api_spec.rb | 2 + spec/unit/api/media_api_spec.rb | 2 + spec/unit/api/messages_api_spec.rb | 2 + spec/unit/api/mfa_api_spec.rb | 2 + spec/unit/api/multi_channel_api_spec.rb | 2 + spec/unit/api/phone_number_lookup_api_spec.rb | 2 + spec/unit/api/recordings_api_spec.rb | 2 + spec/unit/api/statistics_api_spec.rb | 2 + .../api/toll_free_verification_api_spec.rb | 2 + spec/unit/api/transcriptions_api_spec.rb | 2 + spec/unit/client/configuration_spec.rb | 1 + spec/unit/constants.rb | 6 +++ 30 files changed, 95 insertions(+), 65 deletions(-) create mode 100644 spec/smoke/smoke_helper.rb create mode 100644 spec/unit/constants.rb diff --git a/.github/workflows/test-pr.yml b/.github/workflows/test-pr.yml index 67a7a2f1..424945ad 100644 --- a/.github/workflows/test-pr.yml +++ b/.github/workflows/test-pr.yml @@ -9,20 +9,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.head_ref }} cancel-in-progress: true -env: - BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID || '9900000' }} - BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }} - BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }} - BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID || 'abc12345-6def-abc1-2345-6defabc12345' }} - BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID || 'abc12345-6def-abc1-2345-6defabc12345' }} - BW_NUMBER: ${{ secrets.BW_NUMBER || '+19195551234' }} - USER_NUMBER: ${{ secrets.USER_NUMBER || '+19195554321' }} - BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL || 'https://example.com' }} - MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }} - MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }} - MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL || 'https://example.com' }} - MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }} - jobs: test: name: Test PR @@ -46,7 +32,4 @@ jobs: npm install -g @stoplight/prism-cli bundle install prism mock ./bandwidth.yml & (sleep 4; rake unit) - env: - RUBY_VERSION: ${{ matrix.ruby-version }} - OPERATING_SYSTEM: ${{ matrix.os }} shell: bash diff --git a/Rakefile b/Rakefile index f595f003..c7098f4c 100644 --- a/Rakefile +++ b/Rakefile @@ -16,7 +16,7 @@ begin t.pattern = './spec/smoke/*_spec.rb' end - task default: :spec + task default: :unit rescue LoadError # no rspec available end diff --git a/spec/smoke/calls_api_spec.rb b/spec/smoke/calls_api_spec.rb index 6e30afef..fe8765a6 100644 --- a/spec/smoke/calls_api_spec.rb +++ b/spec/smoke/calls_api_spec.rb @@ -1,4 +1,4 @@ -require_relative '../call_utils' +require_relative 'smoke_helper' # Integration Tests for Bandwidth::CallsApi describe 'CallsApi Integration Tests' do diff --git a/spec/smoke/conferences_api_spec.rb b/spec/smoke/conferences_api_spec.rb index f699fc1f..8b83cd22 100644 --- a/spec/smoke/conferences_api_spec.rb +++ b/spec/smoke/conferences_api_spec.rb @@ -1,4 +1,4 @@ -require_relative '../call_utils' +require_relative 'smoke_helper' # Integration Tests for Bandwidth::ConferencesApi describe 'ConferencesApi Integration Tests' do diff --git a/spec/smoke/endpoints_api_spec.rb b/spec/smoke/endpoints_api_spec.rb index e2bdabbb..6fa8b98c 100644 --- a/spec/smoke/endpoints_api_spec.rb +++ b/spec/smoke/endpoints_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration Tests for Bandwidth::EndpointsApi describe 'EndpointsApi Integration Tests' do before(:all) do diff --git a/spec/smoke/media_api_spec.rb b/spec/smoke/media_api_spec.rb index 3f31dd01..b8736dc4 100644 --- a/spec/smoke/media_api_spec.rb +++ b/spec/smoke/media_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration Tests for Bandwidth::MediaApi describe 'MediaApi Integration Tests' do # media info diff --git a/spec/smoke/messages_api_spec.rb b/spec/smoke/messages_api_spec.rb index f3cbf5cd..938c537f 100644 --- a/spec/smoke/messages_api_spec.rb +++ b/spec/smoke/messages_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration Tests for Bandwidth::MessagesApi describe 'MessagesApi Integration Tests' do # message info diff --git a/spec/smoke/mfa_api_spec.rb b/spec/smoke/mfa_api_spec.rb index 0eacf705..6df221f3 100644 --- a/spec/smoke/mfa_api_spec.rb +++ b/spec/smoke/mfa_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration Tests for Bandwidth::MFAApi describe 'MFAApi Integration Tests' do # mfa info diff --git a/spec/smoke/multi_channel_api_spec.rb b/spec/smoke/multi_channel_api_spec.rb index f8545552..120c1e96 100644 --- a/spec/smoke/multi_channel_api_spec.rb +++ b/spec/smoke/multi_channel_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration tests for Bandwidth::MultiChannelApi describe 'MultiChannelApi' do before(:all) do diff --git a/spec/smoke/phone_number_lookup_api_spec.rb b/spec/smoke/phone_number_lookup_api_spec.rb index bf87533f..5bebf79d 100644 --- a/spec/smoke/phone_number_lookup_api_spec.rb +++ b/spec/smoke/phone_number_lookup_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration tests for Bandwidth::PhoneNumberLookupApi describe 'PhoneNumberLookupApi' do let(:phone_numbers) { [BW_NUMBER, USER_NUMBER] } diff --git a/spec/smoke/recordings_api_spec.rb b/spec/smoke/recordings_api_spec.rb index 547c00a2..f819fdcb 100644 --- a/spec/smoke/recordings_api_spec.rb +++ b/spec/smoke/recordings_api_spec.rb @@ -1,4 +1,4 @@ -require_relative '../call_utils' +require_relative 'smoke_helper' # Integration Tests for Bandwidth::RecordingsApi describe 'RecordingsApi Integration Tests' do diff --git a/spec/smoke/smoke_helper.rb b/spec/smoke/smoke_helper.rb new file mode 100644 index 00000000..48ed353c --- /dev/null +++ b/spec/smoke/smoke_helper.rb @@ -0,0 +1,42 @@ +require_relative '../call_utils' + +RSpec.configure do |config| + config.before(:suite) { + begin + BW_CLIENT_ID = ENV.fetch('BW_CLIENT_ID') + BW_CLIENT_SECRET = ENV.fetch('BW_CLIENT_SECRET') + BW_ACCOUNT_ID = ENV.fetch('BW_ACCOUNT_ID') + BW_VOICE_APPLICATION_ID = ENV.fetch('BW_VOICE_APPLICATION_ID') + BW_MESSAGING_APPLICATION_ID = ENV.fetch('BW_MESSAGING_APPLICATION_ID') + BASE_CALLBACK_URL = ENV.fetch('BASE_CALLBACK_URL') + BW_NUMBER = ENV.fetch('BW_NUMBER') + USER_NUMBER = ENV.fetch('USER_NUMBER') + MANTECA_ACTIVE_NUMBER = ENV.fetch('MANTECA_ACTIVE_NUMBER') + MANTECA_IDLE_NUMBER = ENV.fetch('MANTECA_IDLE_NUMBER') + MANTECA_BASE_URL = ENV.fetch('MANTECA_BASE_URL') + MANTECA_APPLICATION_ID = ENV.fetch('MANTECA_APPLICATION_ID') + OPERATING_SYSTEM = ENV.fetch('OPERATING_SYSTEM') + RUBY_VERSION = ENV.fetch('RUBY_VERSION') + rescue + puts 'Environmental variables not found' + exit(-1) + end + + SLEEP_TIME_S = 3 # default sleep time in seconds + MAX_RETRIES = 40 + $active_calls = [] + + $complete_call_body = Bandwidth::UpdateCall.new( + state: Bandwidth::CallStateEnum::COMPLETED + ) + } + + config.after(:suite) { + Bandwidth.configure do |config| + config.client_id = BW_CLIENT_ID + config.client_secret = BW_CLIENT_SECRET + end + calls_api = Bandwidth::CallsApi.new + cleanup_calls($active_calls, calls_api) + } +end diff --git a/spec/smoke/statistics_api_spec.rb b/spec/smoke/statistics_api_spec.rb index 62d51e39..82dc39ec 100644 --- a/spec/smoke/statistics_api_spec.rb +++ b/spec/smoke/statistics_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration Tests for Bandwidth::StatisticsApi describe 'StatisticsApi Integration Tests' do before(:all) do diff --git a/spec/smoke/toll_free_verification_api_spec.rb b/spec/smoke/toll_free_verification_api_spec.rb index b09d5e42..731ce430 100644 --- a/spec/smoke/toll_free_verification_api_spec.rb +++ b/spec/smoke/toll_free_verification_api_spec.rb @@ -1,3 +1,5 @@ +require_relative 'smoke_helper' + # Integration tests for Bandwidth::TollFreeVerificationApi describe 'TollFreeVerificationApi' do before(:all) do diff --git a/spec/smoke/transcriptions_api_spec.rb b/spec/smoke/transcriptions_api_spec.rb index 526d5e8d..c5dd2349 100644 --- a/spec/smoke/transcriptions_api_spec.rb +++ b/spec/smoke/transcriptions_api_spec.rb @@ -1,4 +1,4 @@ -require_relative '../call_utils' +require_relative 'smoke_helper' # Integration Tests for Bandwidth::TranscriptionsApi describe 'TranscriptionsApi Integration Tests' do diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 2105674e..88dd5555 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -19,9 +19,6 @@ # load the gem require 'bandwidth-sdk' -# load call utils every time. This prevents an error from occurring when running only unit tests -require_relative './call_utils' - # The following was generated by the `rspec --init` command. Conventionally, all # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`. # The generated `.rspec` file contains `--require spec_helper` which will cause @@ -41,45 +38,6 @@ # # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration RSpec.configure do |config| - config.before(:suite) { - begin - BW_CLIENT_ID = ENV.fetch('BW_CLIENT_ID') - BW_CLIENT_SECRET = ENV.fetch('BW_CLIENT_SECRET') - BW_ACCOUNT_ID = ENV.fetch('BW_ACCOUNT_ID') - BW_VOICE_APPLICATION_ID = ENV.fetch('BW_VOICE_APPLICATION_ID') - BW_MESSAGING_APPLICATION_ID = ENV.fetch('BW_MESSAGING_APPLICATION_ID') - BASE_CALLBACK_URL = ENV.fetch('BASE_CALLBACK_URL') - BW_NUMBER = ENV.fetch('BW_NUMBER') - USER_NUMBER = ENV.fetch('USER_NUMBER') - MANTECA_ACTIVE_NUMBER = ENV.fetch('MANTECA_ACTIVE_NUMBER') - MANTECA_IDLE_NUMBER = ENV.fetch('MANTECA_IDLE_NUMBER') - MANTECA_BASE_URL = ENV.fetch('MANTECA_BASE_URL') - MANTECA_APPLICATION_ID = ENV.fetch('MANTECA_APPLICATION_ID') - OPERATING_SYSTEM = ENV.fetch('OPERATING_SYSTEM') - RUBY_VERSION = ENV.fetch('RUBY_VERSION') - rescue - puts 'Environmental variables not found' - exit(-1) - end - - SLEEP_TIME_S = 3 # default sleep time in seconds - MAX_RETRIES = 40 - $active_calls = [] - - $complete_call_body = Bandwidth::UpdateCall.new( - state: Bandwidth::CallStateEnum::COMPLETED - ) - } - - config.after(:suite) { - Bandwidth.configure do |config| - config.client_id = BW_CLIENT_ID - config.client_secret = BW_CLIENT_SECRET - end - calls_api = Bandwidth::CallsApi.new - cleanup_calls($active_calls, calls_api) - } - RSpec::Matchers.define(:be_one_of) do |expected| match do |actual| expected.include?(actual) diff --git a/spec/unit/api/calls_api_spec.rb b/spec/unit/api/calls_api_spec.rb index 94ef82f8..ec9063a6 100644 --- a/spec/unit/api/calls_api_spec.rb +++ b/spec/unit/api/calls_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::CallsApi describe 'CallsApi' do let(:call_id) { 'c-1234' } @@ -174,7 +176,7 @@ it 'creates and updates a call' do update_call_body = Bandwidth::UpdateCall.new( state: Bandwidth::CallStateEnum::ACTIVE, - redirect_url: MANTECA_BASE_URL + '/bxml/pause' + redirect_url: BASE_CALLBACK_URL + '/bxml/pause' ) _data, status_code = @calls_api_instance.update_call_with_http_info(BW_ACCOUNT_ID, call_id, update_call_body) diff --git a/spec/unit/api/conferences_api_spec.rb b/spec/unit/api/conferences_api_spec.rb index d2d0e211..fbb0fecd 100644 --- a/spec/unit/api/conferences_api_spec.rb +++ b/spec/unit/api/conferences_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::ConferencesApi describe 'ConferencesApi' do let(:call_id) { 'c-1234' } diff --git a/spec/unit/api/endpoints_api_spec.rb b/spec/unit/api/endpoints_api_spec.rb index fa720496..0b01dd23 100644 --- a/spec/unit/api/endpoints_api_spec.rb +++ b/spec/unit/api/endpoints_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::EndpointsApi describe 'EndpointsApi' do let(:endpoint_id) { 'ep-abc123' } diff --git a/spec/unit/api/media_api_spec.rb b/spec/unit/api/media_api_spec.rb index 51556701..65526783 100644 --- a/spec/unit/api/media_api_spec.rb +++ b/spec/unit/api/media_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::MediaApi describe 'MediaApi' do # media info diff --git a/spec/unit/api/messages_api_spec.rb b/spec/unit/api/messages_api_spec.rb index ee2a144f..441a9296 100644 --- a/spec/unit/api/messages_api_spec.rb +++ b/spec/unit/api/messages_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::MessagesApi describe 'MessagesApi' do before(:all) do diff --git a/spec/unit/api/mfa_api_spec.rb b/spec/unit/api/mfa_api_spec.rb index 3fcebfa8..441e1855 100644 --- a/spec/unit/api/mfa_api_spec.rb +++ b/spec/unit/api/mfa_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::MFAApi describe 'MFAApi' do let(:message) { 'Your temporary {NAME} {SCOPE} code is: {CODE}' } diff --git a/spec/unit/api/multi_channel_api_spec.rb b/spec/unit/api/multi_channel_api_spec.rb index bf738e52..fc0517f1 100644 --- a/spec/unit/api/multi_channel_api_spec.rb +++ b/spec/unit/api/multi_channel_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::MultiChannelApi describe 'MultiChannelApi' do before(:all) do diff --git a/spec/unit/api/phone_number_lookup_api_spec.rb b/spec/unit/api/phone_number_lookup_api_spec.rb index c1ff3007..71506b37 100644 --- a/spec/unit/api/phone_number_lookup_api_spec.rb +++ b/spec/unit/api/phone_number_lookup_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::PhoneNumberLookupApi describe 'PhoneNumberLookupApi' do let(:phone_numbers) { [BW_NUMBER, USER_NUMBER] } diff --git a/spec/unit/api/recordings_api_spec.rb b/spec/unit/api/recordings_api_spec.rb index b2133355..e46541ed 100644 --- a/spec/unit/api/recordings_api_spec.rb +++ b/spec/unit/api/recordings_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::RecordingsApi describe 'RecordingsApi' do let(:call_id) { 'c-1234' } diff --git a/spec/unit/api/statistics_api_spec.rb b/spec/unit/api/statistics_api_spec.rb index 2358ac83..b926914a 100644 --- a/spec/unit/api/statistics_api_spec.rb +++ b/spec/unit/api/statistics_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::StatisticsApi describe 'StatisticsApi' do before(:all) do diff --git a/spec/unit/api/toll_free_verification_api_spec.rb b/spec/unit/api/toll_free_verification_api_spec.rb index 34d138df..87929e63 100644 --- a/spec/unit/api/toll_free_verification_api_spec.rb +++ b/spec/unit/api/toll_free_verification_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::TollFreeVerificationApi describe 'TollFreeVerificationApi' do let (:webhook_subscription_request_schema) { Bandwidth::WebhookSubscriptionRequestSchema.new( diff --git a/spec/unit/api/transcriptions_api_spec.rb b/spec/unit/api/transcriptions_api_spec.rb index 0052257a..f3608db1 100644 --- a/spec/unit/api/transcriptions_api_spec.rb +++ b/spec/unit/api/transcriptions_api_spec.rb @@ -1,3 +1,5 @@ +require_relative '../constants' + # Unit tests for Bandwidth::TranscriptionsApi describe 'TranscriptionsApi' do let(:call_id) { 'c-1234' } diff --git a/spec/unit/client/configuration_spec.rb b/spec/unit/client/configuration_spec.rb index fedea4e0..2fd0d516 100644 --- a/spec/unit/client/configuration_spec.rb +++ b/spec/unit/client/configuration_spec.rb @@ -1,4 +1,5 @@ require 'uri' +require_relative '../constants' # Unit tests for Bandwidth::Configuration describe Bandwidth::Configuration do diff --git a/spec/unit/constants.rb b/spec/unit/constants.rb new file mode 100644 index 00000000..143bfe5d --- /dev/null +++ b/spec/unit/constants.rb @@ -0,0 +1,6 @@ +BW_ACCOUNT_ID = '9900000' +BW_NUMBER = '+19195551234' +USER_NUMBER = '+19195554321' +BW_VOICE_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345' +BW_MESSAGING_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345' +BASE_CALLBACK_URL = 'https://example.com' From 81aa5899453397f6dbabfe319e8424c7def0df39 Mon Sep 17 00:00:00 2001 From: ckoegel Date: Wed, 4 Nov 2026 15:44:28 -0500 Subject: [PATCH 2/2] more cleanup --- .github/workflows/deploy.yml | 16 ---------------- .github/workflows/test-smoke.yml | 2 -- spec/smoke/smoke_helper.rb | 1 - 3 files changed, 19 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 5eefe8fd..7f56950b 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -12,22 +12,6 @@ jobs: permissions: contents: read id-token: write - env: - BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }} - BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }} - BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }} - BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID }} - BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID }} - BW_NUMBER: ${{ secrets.BW_NUMBER }} - USER_NUMBER: ${{ secrets.USER_NUMBER }} - BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }} - RUBY_VERSION: "4.0" - OPERATING_SYSTEM: "ubuntu" - MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }} - MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }} - MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }} - MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }} - BW_NUMBER_PROVIDER: ${{ secrets.BW_NUMBER_PROVIDER }} steps: - name: Set Release Version diff --git a/.github/workflows/test-smoke.yml b/.github/workflows/test-smoke.yml index 244cbf42..4eab49cb 100644 --- a/.github/workflows/test-smoke.yml +++ b/.github/workflows/test-smoke.yml @@ -45,7 +45,6 @@ jobs: bundle install rake smoke env: - RUBY_VERSION: 3.4 OPERATING_SYSTEM: ubuntu shell: bash @@ -74,7 +73,6 @@ jobs: bundle install rake smoke env: - RUBY_VERSION: 3.4 OPERATING_SYSTEM: ubuntu shell: bash diff --git a/spec/smoke/smoke_helper.rb b/spec/smoke/smoke_helper.rb index 48ed353c..330196ab 100644 --- a/spec/smoke/smoke_helper.rb +++ b/spec/smoke/smoke_helper.rb @@ -16,7 +16,6 @@ MANTECA_BASE_URL = ENV.fetch('MANTECA_BASE_URL') MANTECA_APPLICATION_ID = ENV.fetch('MANTECA_APPLICATION_ID') OPERATING_SYSTEM = ENV.fetch('OPERATING_SYSTEM') - RUBY_VERSION = ENV.fetch('RUBY_VERSION') rescue puts 'Environmental variables not found' exit(-1)