From abe0e56fdd1b6025dea2ca752ca5ae72fbff7ed7 Mon Sep 17 00:00:00 2001 From: ckoegel Date: Wed, 4 Nov 2026 15:21:16 -0500 Subject: [PATCH 1/3] DX-4156 Remove Env Vars from Unit Tests --- .github/workflows/test-pr.yml | 14 -------------- tests/unit/api/calls-api.test.ts | 3 ++- tests/unit/api/conferences-api.test.ts | 5 +++-- tests/unit/api/media-api.test.ts | 1 + tests/unit/api/messages-api.test.ts | 1 + tests/unit/api/mfaapi.test.ts | 1 + tests/unit/api/multi-channel-api.test.ts | 1 + tests/unit/api/phone-number-lookup-api.test.ts | 1 + tests/unit/api/recordings-api.test.ts | 3 ++- tests/unit/api/statistics-api.test.ts | 1 + tests/unit/api/toll-free-verification-api.test.ts | 1 + tests/unit/api/transcriptions-api.test.ts | 1 + tests/unit/constants.ts | 6 ++++++ 13 files changed, 21 insertions(+), 18 deletions(-) create mode 100644 tests/unit/constants.ts diff --git a/.github/workflows/test-pr.yml b/.github/workflows/test-pr.yml index 22f5811..7bce22f 100644 --- a/.github/workflows/test-pr.yml +++ b/.github/workflows/test-pr.yml @@ -9,20 +9,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.head_ref }} cancel-in-progress: true -env: - BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }} - BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }} - BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }} - BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID }} - BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID }} - BW_NUMBER: ${{ secrets.BW_NUMBER }} - USER_NUMBER: ${{ secrets.USER_NUMBER }} - BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }} - MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }} - MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }} - MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }} - MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }} - jobs: test: name: Test PR diff --git a/tests/unit/api/calls-api.test.ts b/tests/unit/api/calls-api.test.ts index 87b8a7b..678750a 100644 --- a/tests/unit/api/calls-api.test.ts +++ b/tests/unit/api/calls-api.test.ts @@ -1,6 +1,7 @@ import axios from 'axios'; import { CallsApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_VOICE_APPLICATION_ID, BASE_CALLBACK_URL } from '../constants'; import { CallbackMethodEnum, CallDirectionEnum, @@ -138,7 +139,7 @@ describe('CallsApi', () => { test('should update a call', async () => { const updateCallBody: UpdateCall = { state: CallStateEnum.Active, - redirectUrl: `${MANTECA_BASE_URL}/bxml/pause` + redirectUrl: `${BASE_CALLBACK_URL}/bxml/pause` }; const { status } = await callsApi.updateCall(BW_ACCOUNT_ID, callId, updateCallBody); diff --git a/tests/unit/api/conferences-api.test.ts b/tests/unit/api/conferences-api.test.ts index 9dbefc6..96d2efc 100644 --- a/tests/unit/api/conferences-api.test.ts +++ b/tests/unit/api/conferences-api.test.ts @@ -1,5 +1,6 @@ import { ConferencesApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID, BASE_CALLBACK_URL } from '../constants'; import { ConferenceStateEnum, RedirectMethodEnum, @@ -79,11 +80,11 @@ describe('ConferencesApi', () => { test('should update conference', async () => { const updateConferenceBody: UpdateConference = { status: ConferenceStateEnum.Active, - redirectUrl: `${MANTECA_BASE_URL}/bxml/pause`, + redirectUrl: `${BASE_CALLBACK_URL}/bxml/pause`, redirectMethod: RedirectMethodEnum.Post, username: 'username', password: 'password', - redirectFallbackUrl: `${MANTECA_BASE_URL}/bxml/pause`, + redirectFallbackUrl: `${BASE_CALLBACK_URL}/bxml/pause`, redirectFallbackMethod: RedirectMethodEnum.Post, fallbackUsername: 'username', fallbackPassword: 'password' diff --git a/tests/unit/api/media-api.test.ts b/tests/unit/api/media-api.test.ts index 1bd7811..c2d1858 100644 --- a/tests/unit/api/media-api.test.ts +++ b/tests/unit/api/media-api.test.ts @@ -1,5 +1,6 @@ import { MediaApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID } from '../constants'; describe('MediaApi', () => { const config = new Configuration({ diff --git a/tests/unit/api/messages-api.test.ts b/tests/unit/api/messages-api.test.ts index da5f7bb..40a1df1 100644 --- a/tests/unit/api/messages-api.test.ts +++ b/tests/unit/api/messages-api.test.ts @@ -1,6 +1,7 @@ import axios from 'axios'; import { MessagesApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_MESSAGING_APPLICATION_ID } from '../constants'; import { ListMessageDirectionEnum, MessageDirectionEnum, diff --git a/tests/unit/api/mfaapi.test.ts b/tests/unit/api/mfaapi.test.ts index 72902a4..857f58b 100644 --- a/tests/unit/api/mfaapi.test.ts +++ b/tests/unit/api/mfaapi.test.ts @@ -1,6 +1,7 @@ import axios from 'axios'; import { MFAApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_VOICE_APPLICATION_ID, BW_MESSAGING_APPLICATION_ID } from '../constants'; import { CodeRequest, VerifyCodeRequest } from '../../../models'; describe('MFAApi', () => { diff --git a/tests/unit/api/multi-channel-api.test.ts b/tests/unit/api/multi-channel-api.test.ts index cb0a85a..7c3a536 100644 --- a/tests/unit/api/multi-channel-api.test.ts +++ b/tests/unit/api/multi-channel-api.test.ts @@ -1,6 +1,7 @@ //@ts-nocheck import { MultiChannelApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER, BW_MESSAGING_APPLICATION_ID } from '../constants'; import { MultiChannelChannelListRBMObject, MultiChannelMessageChannelEnum, diff --git a/tests/unit/api/phone-number-lookup-api.test.ts b/tests/unit/api/phone-number-lookup-api.test.ts index 3a678cd..eaad751 100644 --- a/tests/unit/api/phone-number-lookup-api.test.ts +++ b/tests/unit/api/phone-number-lookup-api.test.ts @@ -1,5 +1,6 @@ import { PhoneNumberLookupApi } from "../../../api"; import { Configuration } from "../../../configuration"; +import { BW_ACCOUNT_ID, BW_NUMBER, USER_NUMBER } from "../constants"; import { AsyncLookupRequest, CompletedLookupStatusEnum, diff --git a/tests/unit/api/recordings-api.test.ts b/tests/unit/api/recordings-api.test.ts index e48ddba..32ff296 100644 --- a/tests/unit/api/recordings-api.test.ts +++ b/tests/unit/api/recordings-api.test.ts @@ -1,5 +1,6 @@ import { RecordingsApi } from "../../../api"; import { Configuration } from "../../../configuration"; +import { BW_ACCOUNT_ID, BASE_CALLBACK_URL } from "../constants"; import { CallDirectionEnum, FileFormatEnum, @@ -135,7 +136,7 @@ describe('RecordingsApi', () => { describe('transcribeCallRecording', () => { test('should create a transcription request', async () => { const transcribeRecording: TranscribeRecording = { - callbackUrl: `${MANTECA_BASE_URL}/transcriptions`, + callbackUrl: `${BASE_CALLBACK_URL}/transcriptions`, tag: callId }; const { status } = diff --git a/tests/unit/api/statistics-api.test.ts b/tests/unit/api/statistics-api.test.ts index 5989905..5e8efb8 100644 --- a/tests/unit/api/statistics-api.test.ts +++ b/tests/unit/api/statistics-api.test.ts @@ -1,6 +1,7 @@ import axios from 'axios'; import { StatisticsApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID } from '../constants'; describe('StatisticsApi', () => { const config = new Configuration({ diff --git a/tests/unit/api/toll-free-verification-api.test.ts b/tests/unit/api/toll-free-verification-api.test.ts index 11b9a72..4c2b70c 100644 --- a/tests/unit/api/toll-free-verification-api.test.ts +++ b/tests/unit/api/toll-free-verification-api.test.ts @@ -1,5 +1,6 @@ import { TollFreeVerificationApi } from '../../../api'; import { Configuration } from '../../../configuration'; +import { BW_ACCOUNT_ID } from '../constants'; import { BusinessEntityTypeEnum, BusinessRegistrationTypeEnum, diff --git a/tests/unit/api/transcriptions-api.test.ts b/tests/unit/api/transcriptions-api.test.ts index c46bbf7..ecc9332 100644 --- a/tests/unit/api/transcriptions-api.test.ts +++ b/tests/unit/api/transcriptions-api.test.ts @@ -1,5 +1,6 @@ import { TranscriptionsApi } from "../../../api"; import { Configuration } from "../../../configuration"; +import { BW_ACCOUNT_ID } from "../constants"; import { CallTranscriptionDetectedLanguageEnum, CallTranscriptionTrackEnum } from "../../../models"; describe('TranscriptionsApi', () => { diff --git a/tests/unit/constants.ts b/tests/unit/constants.ts new file mode 100644 index 0000000..5eaacc4 --- /dev/null +++ b/tests/unit/constants.ts @@ -0,0 +1,6 @@ +export const BW_ACCOUNT_ID = '9900000'; +export const BW_NUMBER = '+19195551234'; +export const USER_NUMBER = '+19195554321'; +export const BW_VOICE_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345'; +export const BW_MESSAGING_APPLICATION_ID = 'abc12345-6def-abc1-2345-6defabc12345'; +export const BASE_CALLBACK_URL = 'https://example.com'; From 7cb5b06edd3c2f0075d1ae0d9e0321c850412307 Mon Sep 17 00:00:00 2001 From: ckoegel Date: Wed, 4 Nov 2026 15:39:50 -0500 Subject: [PATCH 2/3] remove OS var --- .github/workflows/test-pr.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test-pr.yml b/.github/workflows/test-pr.yml index 7bce22f..ae0824b 100644 --- a/.github/workflows/test-pr.yml +++ b/.github/workflows/test-pr.yml @@ -32,6 +32,4 @@ jobs: yarn npm install -g @stoplight/prism-cli prism mock ./bandwidth.yml & yarn test-unit - env: - OPERATING_SYSTEM: ${{ matrix.os }} shell: bash From d6051ee1eb931a5a3a7bdc328582ebb181e58776 Mon Sep 17 00:00:00 2001 From: ckoegel Date: Wed, 4 Nov 2026 15:43:05 -0500 Subject: [PATCH 3/3] remove from deploy --- .github/workflows/deploy.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 7fbecc3..c2e4ddb 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -13,21 +13,6 @@ jobs: deploy: name: Deploy SDK to NPM runs-on: ubuntu-latest - env: - BW_ACCOUNT_ID: ${{ secrets.BW_ACCOUNT_ID }} - BW_CLIENT_ID: ${{ secrets.BW_CLIENT_ID }} - BW_CLIENT_SECRET: ${{ secrets.BW_CLIENT_SECRET }} - BW_VOICE_APPLICATION_ID: ${{ secrets.BW_VOICE_APPLICATION_ID }} - BW_MESSAGING_APPLICATION_ID: ${{ secrets.BW_MESSAGING_APPLICATION_ID }} - BW_NUMBER: ${{ secrets.BW_NUMBER }} - USER_NUMBER: ${{ secrets.USER_NUMBER }} - BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }} - OPERATING_SYSTEM: "ubuntu" - MANTECA_ACTIVE_NUMBER: ${{ secrets.MANTECA_ACTIVE_NUMBER }} - MANTECA_IDLE_NUMBER: ${{ secrets.MANTECA_IDLE_NUMBER }} - MANTECA_BASE_URL: ${{ secrets.MANTECA_BASE_URL }} - MANTECA_APPLICATION_ID: ${{ secrets.MANTECA_APPLICATION_ID }} - BW_NUMBER_PROVIDER: ${{ secrets.BW_NUMBER_PROVIDER }} steps: - name: Set Release Version